jQuery failed to expose after update to 0.7.2 about expose-loader

[FeliciousX]

can confirm there's a breaking change..

  { test : resolve.require('jquery'), loader : 'expose-loader?jQuery' },
  { test : resolve.require('jquery'), loader : 'expose-loader?$' },

the order matters.. the first one goes through but $ does not.

doing this

{ test: resolve.require('jquery'), loader: 'expose-loader?jQuery!expose-loader?$' }

also doesn't expose $ as jquery .. order matters again.. strange

in version 0.7.1 it works fine for either cases

[joshwiens]

@rowanhill @jimbolla - Please pick up 0.7.3 and ping me back if you are still having issues.

Anyone in the thread that has a public project throw up a link, i'm going to write some unit tests for this loader and I'd like to cover as many of your use cases as possible.

[chenxeed]

Hi, I upgraded my package to 0.7.3 and it's fixed now, thanks a lot! I'll close this issue now.

[chenxeed]

FYI, this is my webpack config to expose jquery. It's still working on 0.7.1.

  { test : /jquery\.js$/, loader : 'expose-loader?$' },
  { test : /jquery\.js$/, loader : 'expose-loader?jQuery' },

[Boshen]

After 7ae08d1

module.exports = global["$"] = require("-!/web/node_modules/expose-loader/index.js?jQuery!/web/node_modules/source-map-loader/index.js!/web/node_modules/jquery/dist/jquery.js");

becomes

module.exports = global["$"] = require("-!./jquery.js");

which breaks the build

[stephencookdev]

This seems to be the case for all multiple aliases to one library (i.e., does not just affect jQuery)

[jvmccarthy]

Yes, I think what's going on here is that the fix in #28 doesn't account for other loaders to be used in sequence. In my case, I have to shim a module with both exports and expose loaders in sequence. I think when the path was changed to relative, the other loader information was stripped off.

[cletusw]

This is also affecting my company. Temporarily pinned our build at v0.7.1

[gdborton]

Let me know if I can help in any way with the tests. I wanted to add some to the original pr, but I didn't know if my approach was the best.

[jimbolla]

0.7.3 worked for me. Thanks.

[rowanhill]

@d3viant0ne I'm afraid my repo isn't public, but I'm happy to confirm that 0.7.3 has fixed things for me.

Thanks for responding so quickly!

[joshwiens]

Cool & no problem :)