Coder Social home page Coder Social logo

Comments (4)

pablothedude avatar pablothedude commented on August 26, 2024

Confirmed, but should the validation also pass with Chinese characters and be independent of the active locale? As this will going to happen after the suggested change?

from assert.

BackEndTea avatar BackEndTea commented on August 26, 2024

Thank you for opening this issue.

Currently, the locale is 'forced', so the ctype based asserts are independent of locale.

If this new assertion gets added, what do you think it should be named?
And how should it handle other cases like Chinese characters as @pablothedude mentioned?

I'd also like to point out that the regex you linked may not work as intended: https://3v4l.org/7M1LZ

from assert.

rossbearman avatar rossbearman commented on August 26, 2024

Ah, the regex will need the u flag in order to enable PHP's Unicode support.

See: https://3v4l.org/sW6Z8

The name Assert::letter() would probably be most appropriate, as it is checking against Unicode's letter character class. As such, supporting Chinese letters would be consistent and clear.

from assert.

BackEndTea avatar BackEndTea commented on August 26, 2024

Ah, the regex will need the u flag in order to enable PHP's Unicode support.

Guess i missed that, it does look more promising now. I think this fits a common enough use case to add this to the libary, so feel free to open a PR.

from assert.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.