Coder Social home page Coder Social logo

Comments (4)

sovoid avatar sovoid commented on June 28, 2024 1

Thank you for a very nicely described issue!
Just curious though, what kind of actions do not correspond to an endpoint?

I guess those instances where we perform a script injection using browser.execute don't get registered as a JSON wire endpoint. I was planning on doing a short POC on confirming the same. Hopefully with v3.1 we should be able to confirm this behaviour.

from wdio-video-reporter.

sovoid avatar sovoid commented on June 28, 2024

@presidenten I am not sure how to appropriately title this issue, but this should be an easy PR.

Also do you think it we should make the following check optional:

!config.jsonWireActions.includes(commandName)

as if the endpoint does not exist, no videos will be recorded?

from wdio-video-reporter.

presidenten avatar presidenten commented on June 28, 2024

Thank you for a very nicely described issue!
Just curious though, what kind of actions do not correspond to an endpoint?

from wdio-video-reporter.

presidenten avatar presidenten commented on June 28, 2024

(Merged your pr in v3.1.0)

from wdio-video-reporter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.