Coder Social home page Coder Social logo

CRLF line endings about wcdocker HOT 5 CLOSED

webcabin avatar webcabin commented on July 27, 2024
CRLF line endings

from wcdocker.

Comments (5)

Lochemage avatar Lochemage commented on July 27, 2024

@bulentv

I have added a gitattributes file, I am not entirely sure how this works, it didn't seem to make any of my current files change to LF style, but that may just be because I am running on Windows.

I am going to rely on you to let me know if this corrects the line endings on your side.

from wcdocker.

bulentv avatar bulentv commented on July 27, 2024

@Lochemage

.gitattributes looks correct to me. But the files are still being checked out as CRLF and it turns out that there is one more change to make the repo cross-compatible in line-endings aspect.

I did it on my fork and tested on both windows and linux. Windows version of git checks out the files with CRLF and linux git does only LF, and also does the reverse on commit/push which is what is what exactly expected.

But as you can see, unfortunately this commit touches every single file that is listed as text in .gitattributes to remove "CR" to make it compatible which is kind of a huge change tough there is absolutely no change on the code.

I'm anyway making this as a pull request. So as the owner of the repo, it is up to you to accept it and pull the commit or not.

There is an alternative solution that does the same but in the whole history of repo and without changing or adding any commits.

from wcdocker.

Lochemage avatar Lochemage commented on July 27, 2024

@bulentv

Thanks! I've merged your update! It looks like fixing the entire history of the project might not be a good idea as it will force all users to re-pull a brand new repo. I think it should be ok, though, you don't plan to roll-back to a previous version, do you?

from wcdocker.

bulentv avatar bulentv commented on July 27, 2024

Wow, thank you for accepting it! And no I don't plan a roll-back.
So, now I can do more contribution to leave this very commit in the past :)

from wcdocker.

Lochemage avatar Lochemage commented on July 27, 2024

@bulentv

Great! I look forward to more contributions!

from wcdocker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.