Coder Social home page Coder Social logo

Comments (5)

keithw avatar keithw commented on June 24, 2024

Thanks for reporting this! Can you please test #2389 and see if it fixes the issue for you?

There should probably be a test for this situation, ideally eventually upstream in the spec tests.

I'm also nervous about MSVC's handling of wasm2c output for conversion instructions given https://github.com/WebAssembly/wabt/blob/main/src/c-writer.cc#L4851 and https://github.com/WebAssembly/wabt/blob/main/src/config.cc#L76 -- we should make sure this is also tested.

from wabt.

rossberg avatar rossberg commented on June 24, 2024

There should probably be a test for this situation, ideally eventually upstream in the spec tests.

@keithw, PTAL at this spec PR.

from wabt.

InflexCZE avatar InflexCZE commented on June 24, 2024

#2389 looks good, no unexpected overhead either
https://godbolt.org/z/xf4Wfa4Ev

  1. Might be good to export with //decimal value comment at the end of the line, for users' convenience
  2. Will prolly need byte re-order for little-endian

from wabt.

SoniEx2 avatar SoniEx2 commented on June 24, 2024

it works fine on both endian

from wabt.

keithw avatar keithw commented on June 24, 2024

#2389 looks good, no unexpected overhead either https://godbolt.org/z/xf4Wfa4Ev

1. Might be good to export with `//decimal value` comment at the end of the line, for users' convenience

Thanks, good idea. Done in #2389.

from wabt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.