Comments (8)
Regarding option 6: instead of adding a dependency on the multi-value proposal, this proposal could just clone the part of the multi-value proposal that generalizes instructions to yield more than one value; that's a simple and non-controversial part of that proposal, and all that's necessary for table.grow
to yield 2 results in this proposal.
from reference-types.
So... we have a MaxTableLength of 1e7. I thought this limit was generally agreed upon since WebAssembly/spec#873. Doesn't that prevent this from being an issue?
from reference-types.
@lars-t-hansen, that's a web-specific limit, not one inherent to Wasm per se.
from reference-types.
OK, fair point about the web embedding.
The size of a table is limited to what table.size
can return, ie, 2^32-1. The only time table.grow
can be called on a table and return 2^32-1 and that can be not-an-error is when the table size is already 2^32-1 and the delta is zero.
My preference here would actually be to choose (1) because it fits the current design, and then, once we have multi-value and/or exceptions and/or shared tables, revisit both memory.grow and table.grow to see if there are more principled solutions.
In a similar but not quite analogous situation, we chose to trap (WebAssembly/threads#72). We could do that here too.
from reference-types.
I prefer (1) or (6) (w/ @AndrewScheidecker's modification). Mostly because I prefer the symmetry w/ memory.grow
and want to avoid raciness.
from reference-types.
from reference-types.
@titzer, I'm not sure I understand your comment re option (6). It does not change the definition of what is a "successful" grow nor whether Wasm code can observe that result, so any such weirdness is no different than with the other options.
from reference-types.
The majority voice seems to be to leave the wart alone, so I'm closing this.
from reference-types.
Related Issues (20)
- [js-api] Formalization only: eliminate extern value cache HOT 7
- Who is responsible for table.grow? HOT 3
- `table.fill` needs to bounds check before executing `table.set`? HOT 3
- Missing validation step for ref.null HOT 3
- Typeability Bug in Reference Implementation HOT 5
- Evaluating initializer expressions in element segments when instantiating HOT 2
- Failure string in core tests HOT 1
- Bug in reference core test HOT 4
- "refedtype" unnecessary HOT 4
- Rename "refedtype" to "heaptype" HOT 1
- Missing design rationals for type annotated select HOT 3
- There is no DefaultValue for anyfunc/funcref HOT 1
- may have a wrong leading byte here HOT 1
- Constant Expressions constraint HOT 6
- Is there a browser support table? HOT 3
- [Support] Are mixed (`anyref`) tables still supported, and if so, how are they encoded? HOT 3
- s/anyref/externref in repo description HOT 3
- Archive repo? HOT 1
- New `select` variant is not documented in Overview HOT 1
- Remove type annotation on ref.is_null HOT 22
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reference-types.