Restarting a server leads to metrics re-registration issues about common

[bboreham]

I think, under your proposal, if this library was used in a program which happened to also use the same metric name for something else, things could get confusing.

How about splitting server.New() into a function which registers the metrics and a function which creates the server? And leave the existing API creating a singleton which lasts the life of the program.

[thampiotr]

I think, under your proposal, if this library was used in a program which happened to also use the same metric name for something else, things could get confusing.

Thanks @bboreham, that's a very good point!

How about splitting server.New() into a function which registers the metrics and a function which creates the server? And leave the existing API creating a singleton which lasts the life of the program.

I've drafted this solution to see how it looks here: #289. It looks good to me - let me know if you have any early feedback. I'll add some tests before marking it as ready for review.

[thampiotr]

I've added tests and the change is now ready for review: #289