SQL lexer doesn't understand dollar-quoted values about ragtime

[weavejester]

The whole SQL parser needs to be replaced with something more reliable, it's just a case of finding time to do it. Even something as simple as separating SQL statements is just too prone to edge cases.

@rkneufeld I had similar issues with the parsing of stored procedures... it motivated me to take a different approach and avoid the complexity of parsing sql files... you might take a look at this ( https://github.com/ckuttruff/clj-sql-up ) - which works as you'd expect with more complicated sql syntax

[weavejester]

Out of interest, @ckuttruff, what made you decide to create a migration plugin rather than hook into Ragtime?

Hey @weavejester
I originally had that intention with this PR ( #18 ), but it seemed like not the best approach given the way things were currently structured with ragtime and the expectation of specifying migrations as sql files. The way of modeling migration statements as a vector of sql strings seemed much simpler (avoiding the necessary parsing logic), but obviously would be a breaking paradigm shift for ragtime.

Apologies if this was perceived as a lack of desire to contribute to ragtime... that is certainly not the case. Given my limited clojure experience, and the need to maintain backwards compatibility, it was much simpler for me to attack the issue from a blank slate

[weavejester]

Ragtime doesn't have an opinion on how migrations are specified. You just need to provide it with a function that returns a sequence of migration maps.

Presumably you wrote clj-sql-up from scratch because you were unaware of that?

hmm, well I actually wrote clj-sql-up for a variety of reasons; it was a great learning opportunity amongst other things.

But no, I was not aware aware of an alternative method for specifying migration content beyond sql files; was just going off the documentation here: https://github.com/weavejester/ragtime/wiki/Getting-Started#migrations20120903221323-add-test-tableupsql which just specifies creating plain sql files under a migrations directory.

Thanks for the prompt response and sorry if there was more I could have done to contribute to ragtime; just wanted to mention an alternate solution on this issue thread that doesn't run into some of the parsing issues that @rkneufeld and others have encountered in this particular situation.

[weavejester]

No need to apologise! I was just curious as to your reasoning, as that would give me an idea of what could be improved.

The Ragtime README could do a better job at explaining the library, and how different migration strategies could be used.

[weavejester]

Should be fixed by version 0.4.0 redesign.