Coder Social home page Coder Social logo

Comments (4)

weavejester avatar weavejester commented on August 18, 2024

Can you explain a little further? How is the content of :mvn/version being passed into the running process?

from codox.

cap10morgan avatar cap10morgan commented on August 18, 2024

Like that code I link to demonstrates, when a value is a keyword, you just check if that keyword is an alias in the project basis (i.e. the deps.edn file). If it is, use the value of that alias in place of the original keyword in the exec-args.

Getting the aliases: https://github.com/seancorfield/depstar/blob/d15af202cc796eecf9ef1b7df1c2108d4ee0a202/src/hf/depstar/task.clj#L23-L26

Putting the value of the alias into the opts map when it a) exists and b) isn't an exec-arg that's supposed to be a keyword: https://github.com/seancorfield/depstar/blob/d15af202cc796eecf9ef1b7df1c2108d4ee0a202/src/hf/depstar/task.clj#L28-L34

from codox.

weavejester avatar weavejester commented on August 18, 2024

I don't think this is a good idea, because it's counter to the ethos of simplicity that tools.deps follows. If we change generate-docs to have behaviour dependent on deps.edn, that's a source of complexity. It creates a connection between deps.edn and generate-docs that didn't exist previously.

from codox.

cap10morgan avatar cap10morgan commented on August 18, 2024

Yeah, it would be nice if this substitution were done at the tools.deps level so it would just be there by the time you received the exec-args. It’s really unfortunate to have to repeat values like this (and remember to update them in more than one place).

But I hear you, it’s not really within codox’s domain to do this like it is for something like depstar.

I’ll look into other options.

from codox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.