Coder Social home page Coder Social logo

Comments (5)

samuelmeuli avatar samuelmeuli commented on May 18, 2024 1

The problem is that the action is executed on the pull_request event, which it doesn't support yet (only the push event, which lets the action easily determine which commit needs to be annotated).

I'm planning to fix this though :)

from lint-action.

SimenB avatar SimenB commented on May 18, 2024 1

Ah, that makes sense. It should fail the step regardless though, no? Or maybe just explode if ran on an unsupported event altogether

from lint-action.

samuelmeuli avatar samuelmeuli commented on May 18, 2024 1

Or maybe just explode if ran on an unsupported event altogether

Yeah, I expected this to be the current behavior, but it looks like I removed the check at some point 😅 I'll add it back as a temporary solution and will think about how the pull_request event could be supported.

from lint-action.

samuelmeuli avatar samuelmeuli commented on May 18, 2024

Released in v0.6.0

from lint-action.

SimenB avatar SimenB commented on May 18, 2024

Oh, that was quick! Thanks 🎉

from lint-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.