Exit Code and Status about lint-action

[ozum]

@samuelmeuli thanks for the answer. How can I combine results of ESLint and Prettier and conditionally run Release step?

Currently I have a workflow similar to below. (Simplified for example purposes)

  - name: Run linters
    uses: samuelmeuli/lint-action@v1
    with:
      eslint: true
      prettier: true
  - name: Test
    run: jest
  - name: Release
    if: [SHOULD I ADD SOME CONDITION BASED ON PRETTIER AND ESLINT RESULT ???]
    run: npm publish

PS: This is push workflow, not PR

Edit2: I just wanted to prevent release on push, if lint or test fails.

[samuelmeuli]

The action should have created two additional checks for you, named ESLint and Prettier. Details here: #31

[BraveLilToaster]

Normally I would use needs (see docs) in the workflow, but I am having issues with this as well. Since the checks ESLint and Prettier aren't declared in the workflow I can't use needs here.

 - name: Run linters
    uses: samuelmeuli/lint-action@v1
    with:
      eslint: true
      prettier: true
  - name: Test
    run: jest
  - name: Release
    needs: [Prettier, ESLint]
    run: npm publish

[ozum]

@samuelmeuli could you please elaborate?

[BraveLilToaster]

I looked through the source code and realized that the ESLint and Prettier checks that are created here are actual github Checks. I have no idea if these can be depended on to prevent a job like "Release" from being run.