Comments (10)
Would be super sweet to see this get fixed, as I'm running into the same problem.
from diplomat.
Well spotted. The question is - should we detect if the path is recursive and return a different result or should we make it an explicit option that you set?
from diplomat.
I've decided I'm going to return the hash, but I will do this as part of a breaking change, which according to Semver will bump the version number up to 1.0.0. I'll do this after I've merged everything else that's non-breaking in and released 0.13.0.
from diplomat.
@johnhamelink According to Semver, major version 0 (that is, 0.y.z) is for initial development and does not guarantee any protection against breaking changes. You should feel free to break things between minor revisions when you're still in pre-release.
from diplomat.
@chaos95 Agreed, but considering the amount of people using this gem, we are now in release whether we like it or not 😄
from diplomat.
Iam bumping this issue, since with 1.1.0 we have now convert_to_hash: true
and this we can implement a good behavior here.
Right now, if you ask for test/this/out/key = 'test' with
Diplomat::Kv.get('test/', {convert_to_hash: true, recurse: true}, :return)
You get a plain parse exception that test cannot be "eached"
undefined method `each' for "test":String
@johnhamelink it seemed to be on the 1.0.0 roadmap but either it got forgotten or this issue is not the right home for my described bug. Could you tell me whether to create a new context for this?
For more cleanup to this ssue:
Pull request #51 should be closed since it is not based on the current hash-parser or was not aware back then in 2015, that it will be existing. I think, the patch for the issue above is far more trivial
from diplomat.
If it helps anyone, our fork changes behaviour such that single-valued results are packaged the same way as multi-valued ones.
https://github.com/caradvice/diplomat
from diplomat.
@snoremac wondering why you did not create a pull request? Thank you for your work!
from diplomat.
@snoremac thoughts on PRing?
from diplomat.
This has been added in 2.1.0
from diplomat.
Related Issues (20)
- /v1/catalog/register is broken after upgrade to v2.1.2 HOT 1
- Support Consul 1.4.0+ ACL system HOT 2
- Add support for Consul 1.5.x ACL tokens HOT 2
- Add support for Consul 1.5.x Auth Method and Binding Rule HTTP APIs HOT 2
- Improve error message in case of missing ACL
- 2.3.0: syntax error in file lib/diplomat/rest_client.rb:243 ? HOT 4
- It is unable to retrieve service configuration from consul HOT 2
- Add support for Operator Autopilot API HOT 5
- Due to faraday 1.1 release diplomat only works on ruby 2.4+
- Unable to use multiple tags when querying for services HOT 2
- Bump faraday requirement HOT 1
- Register HTTP checks HOT 3
- Add support for default datacenter HOT 3
- Broken link to API documentation HOT 3
- Register entities via agent
- Add blocking read support for service health endpoint HOT 3
- Faraday 2.0.0 breaks diplomat HOT 4
- Faraday 1.x can bypass Diplomat::QueryAlreadyExists HOT 1
- Can't get it to work with auth token given in config HOT 5
- Kv.put() method with Consul v1.10.1 results in KV entries that are visible via CLI/API, but not UI HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from diplomat.