Child nodes retain parent node tag? about xeroizer

[tjschuck]

Just to clarify the issue, that XML sample:

<Invoice>
  <Invoice>
    <ContactID>ac565f9c-9829-4f51-8a5b-0400de972bbb</ContactID>;
    <Name>PowerDirect</Name>
  </Invoice>
 [...]
</Invoice>

should have Contact as its first child instead of Invoice repeated:

<Invoice>
  <Contact>
    <ContactID>ac565f9c-9829-4f51-8a5b-0400de972bbb</ContactID>;
    <Name>PowerDirect</Name>
  </Contact>
 [...]
</Invoice>

[waynerobinson]

Could you please show me the code that you're using to generate this? I've not encountered this issue before with code like:

invoice = gw.Invoice.build(type: "ACCREC", contact: {name: "Contact Name"})
invoice.save

[zmoazeni]

I'm getting this from client.Invoice.first.to_xml. Where the client is the appropriate application. In this case a PartnerApplication

[waynerobinson]

That is… interesting. I will have a look and get back to you. You're right, loading the invoice initialises this as Invoice instead of Contact.

[fimmtiu]

I'm running into this now, too... when I do something like this:

invoice = xeroizer.Invoice.first
contact = invoice.contact
puts xeroizer.CreditNote.build(contact: contact).to_xml

...it serializes as <CreditNote><Invoice>(contact data...)</Invoice></CreditNote>. But if I change it to this:

contact = xeroizer.Contact.first

...it works fine. Something about the fact that it's being pulled from the invoice makes it serialize improperly.

[waynerobinson]

Xeroizer was never really intended to have it's sub-elements re-used in other record types and this is obviously showing through here.

In the meantime, the easiest way to refer to a contact elsewhere is to actually use its unique ID. E.g.

invoice = xeroizer.Invoice.first
contact = invoice.contact
puts xeroizer.CreditNote.build(contact: {id: contact.id}).to_xml

[fimmtiu]

Doesn't work in any case where the model does a validates_associated on the contact association (i.e., credit notes). Just saying {id: contact_id} isn't enough to satisfy validates_associated.

[waynerobinson]

Fixed by @fimmtiu in #96.