Coder Social home page Coder Social logo

Comments (2)

adamcooke avatar adamcooke commented on August 17, 2024

This only happens when calling the method using a PUT request. If the same request is sent as a POST request, the journal is created as appropriate.

I'm not sure why Xero encourages the use of PUT for creating objects as, traditionally, the creation of an object would be sent with a POST. The documentation (for Journals, anyway) says that PUT or POST is permitted for creation which seems a little crazy.

I'm not sure on a fix for this, I'm reluctant to change all creation requests to use POST as I don't have a way to test it easily.

As I'm only using this to add journals, I've pushed a fix to my fork (along with another commit which you may be interested in applying)

Any thoughts?

from xeroizer.

waynerobinson avatar waynerobinson commented on August 17, 2024

I'm not sure what is going on here and haven't had a chance to do my own testing on this at the moment. I know that XeroGateway is having similar problems so there might be a change to the OAuth gem that has broken this.

I will do more testing and get back. If using POSTs for everything (which I will test) solves the problem and Xero themselves give the OK for this, I will merge your pull request.

from xeroizer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.