The function type of wasi_snapshot_preview1::path_readlink is not correct about wasmedge

[L-jasmine]

This should be fixed at this pre-release: https://github.com/WasmEdge/WasmEdge/releases/tag/0.8.2-rc.4
Please use the new binary and try again. Thanks for your report.

it can run in 0.8.2-rc.4

[hydai]

@q82419 Could you check this?

path_readlink is a valid wasi function:
https://github.com/WebAssembly/WASI/blob/main/phases/snapshot/witx/wasi_snapshot_preview1.witx#L372

[hydai]

Seems like our path_readlink function has 6 args whereas WASI spec only has 5 args.

Updated: Our implementation is the same as WASI spec which has 5 args. So it will need to check the wasm file itself to figure out the details.

[L-jasmine]

Seems like our path_readlink function has 6 args whereas WASI spec only has 5 args.

in my wasm path_readlink is (func (param i32 i32 i32 i32 i32 i32) (result i32))

[hydai]

@L-jasmine Could you provide the steps of creating the wasi-quickjs?

After checking the WASI-SDK, the path_readlink should have only 5 args:

https://github.com/WebAssembly/wasi-libc/blob/659ff414560721b1660a19685110e484a081c3d4/libc-bottom-half/sources/__wasilibc_real.c#L473-L488

[q82419]

@L-jasmine
This function was not changed in the past 2 years. Can you provide your WASM file and the source? Thanks.

[L-jasmine]

wasmer: https://github.com/wasmerio/wasmer/blob/master/lib/wasi/src/syscalls/mod.rs#L1907-L1922
wasilibc: https://github.com/WebAssembly/wasi-libc/blob/659ff414560721b1660a19685110e484a081c3d4/libc-bottom-half/sources/__wasilibc_real.c#L473-L476

[q82419]

It seems like the arg5 is defined in the result column.
https://github.com/WebAssembly/WASI/blob/main/phases/snapshot/witx/wasi_snapshot_preview1.witx#L380
We'll fix it and check for other functions. Thanks.

[hydai]

This should be fixed at this pre-release: https://github.com/WasmEdge/WasmEdge/releases/tag/0.8.2-rc.4
Please use the new binary and try again. Thanks for your report.