Cannot build trucks without command center. about warzone2100

[KJeff01]

@maxsupermanhd Can you confirm if these problems happen on the latest master?

[KJeff01]

Closing since trucks don't require an HQ with 9f5168c. Reopen or make a new issue if you find anything else odd happening.

[Forgon2100]

Clearly, that's a bug, likely introduced by #378. Thanks for reporting.

[...] Somebody can build new trucks and somebody can't until command center. [...]

Could you be more precise as to when building trucks is possible while
no HQ has been built? In skirmish games with no HQ being built, I have
only reproduced the absence of truck templates, but not their presence.
Your screenshots give me no additional information about this.
Or did I misunderstand your comment?

Another bug by that PR is that the Machinegun Viper Wheels template is
always available in Alpha 1. Removing the following line of code from
data/base/script/campaign/cam1a.js does not change this:

enableTemplate("ViperLtMGWheels");

[maxsupermanhd]

Could you be more precise as to when building trucks is possible while
no HQ has been built?

So Vaut, me and some other people decided to test master because of my pull request with old weapons accuracy and other good stuff to play with. On second or third game when i built only 2 labs and factory i decided to produce more builders but when opened factory tab screenshots... So one or two games i cant build any units before HQ, when other players can. Next games in voice chat another few players (not all) reported that problem. Unfortunately i still don't know how to fix this.
And i found some logs for this:

error   |23:37:32: [loadDroidTemplates:457] Design id:221480 (Truck Viper Wheels) *NOT* added to UI list (duplicate), player= 1
error   |23:37:32: [loadDroidTemplates:457] Design id:221480 (Truck Viper Wheels) *NOT* added to UI list (duplicate), player= 2
error   |23:37:32: [loadDroidTemplates:457] Design id:221480 (Truck Viper Wheels) *NOT* added to UI list (duplicate), player= 3

EDIT:
Maybe adding enableTemplate("ViperLtMGWheels"); to warzone2100/data/mp/multiplay/skirmish/rules.js can fix this?

[KJeff01]

Another bug by that PR is that the Machinegun Viper Wheels template is
always available in Alpha 1. Removing the following line of code from
data/base/script/campaign/cam1a.js does not change this

Campaign doesn't enforce this rule. Like the multiplayer transporter, it has the available flag set to true. So, if you want that, remove that line from the templates.json base file. It seems the default truck and mg viper are available so using enableTemplate on them is unnecessary except for the tutorial.

I believe why some see their designs and some not depends on if they built an HQ in previous games. Setting it back to false when games load should do the trick.

Patches here should mostly fix this. I made researched truck templates always available now. The one drawback is T2/T3 no bases allows players to use their non-default trucks. Still wondering how to stop that or if there is a better approach.

[KJeff01]

Trucks will now be available without the HQ.

[Forgon2100]

Another bug by that PR is that the Machinegun Viper Wheels template is
always available in Alpha 1. Removing the following line of code from
data/base/script/campaign/cam1a.js does not change this

Campaign doesn't enforce this rule. Like the multiplayer transporter, it has the available flag set to true. So, if you want that, remove that line from the templates.json base file. It seems the default truck and mg viper are available so using enableTemplate on them is unnecessary except for the tutorial. [...]

Thanks. I had gotten used to the buggy behavior before #378 was pushed.
The problem has been fixed in #383, which is now ready to be merged.

[maxsupermanhd]

We will test latest master this evening. (22:00 GMT+3)

[maxsupermanhd]

So me and Vaut tested this for now (works) but there was only two players in here. Cant say that its absolutely tested but hadn't noticed any bugs.