Comments (3)
What I'm personally hoping to avoid is having to hook in a logging library. We could put more of the exception data into the error map, but that ends up being too verbose, and somewhat insecure (leaking implementation details to an unknown client). I don't think I like the idea of an exception callback, so that loops me back to logging.
from lacinia.
@hlship
What's the reason behind not liking exception callbacks? It allows the user to specify how to handle exceptions and at the same time lets lacinia return errors that conform to the spec.
Cheaper alternatives would be to not catch the exceptions and have the user handle it along with spec compliance. Also, implementation details are already being leaked in the form of exception messages (less insecure than a full blown trace, but still).
from lacinia.
Maybe something like an exception sanitizer
callback that could be passed some information about where the exception occured, and the real exception, and is expected to return an error map.
from lacinia.
Related Issues (20)
- Published version 1.1 requires missing namespace HOT 1
- In lacinia 1.1, the trace namespace code (dev only) has a dependency on io.aviso/pretty, which is not declared in deps.edn HOT 2
- icu4j vulnerability HOT 1
- Swallowed unhandled exceptions because of misusage of clojure.core/future HOT 10
- Scalar type which returns vector HOT 4
- ::lacinia/null returned in unions instead of null HOT 1
- Apollo Federation Compatibility HOT 1
- Includes variable-definitions in parsed query HOT 4
- Question: Is there a way to return JSON without a corresponding EDN definition? HOT 3
- Use of executor/selection in streamer functions HOT 1
- Document example of a raw JSON scalar
- cryptic errors when input is the wrong type
- Passing in variables wrapped in an array comes in as a double array HOT 5
- Support @defer and @stream directives
- Convert the keys of arguments and variables to kebab-case HOT 1
- Subscriptions may fail to stream data to the client
- Unbalanced braces in queries not causing parse-query to fail
- Tracing "validation" fields are always null
- Question: Query complexity and depth HOT 2
- Replace antlr4 deps with antlr4-runtime HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lacinia.