Coder Social home page Coder Social logo

Comments (3)

alvestrand avatar alvestrand commented on June 24, 2024

Seems like we want this getter to reflect the content of the currently negotiated SDP description, and this is independent of the SendCodecs and ReceiveCodecs (it's a shorthand for an SDP parser).

from webrtc-pc.

jan-ivar avatar jan-ivar commented on June 24, 2024

Seems like we want this getter to reflect the content of the currently negotiated SDP description,

Yes, that seems a useful way to look at it.

and this is independent of the SendCodecs and ReceiveCodecs (it's a shorthand for an SDP parser).

Internal slots are cheap, as long as we're not confusing things we can do it a couple of ways.

But for consistency with 1.0 (and TR) we may wish to keep [[SendCodecs]] and [[ReceiveCodecs]] the same, doing their old job of reflecting currentDescription (at least as implemented when it comes to [[ReceiveCodecs]]). E.g. start out empty (when currentDescription is null).

In #2956 (comment) I proposed some new internal slots.

from webrtc-pc.

alvestrand avatar alvestrand commented on June 24, 2024

Having slept on it, it seems that we've been using SendCodecs and ReceiveCodecs for two different things:

  • Representing the capabilities of the transceiver (used to be the capabilities of the platform)
  • Representing the current set of negotiated codecs
    It seems logical that this needs to be two different internal slots. The "current set of negotiated codecs" doesn't need the Enabled bit - it can be just a simple representation of what's in the currently valid SDP.

Suggested new names:
[[NegotiatedCodecs]] - occurs both in sender and receiver (has PT, does not have Enabled)
[[AvailableCodecs]] - occurs both in sender and receiver (has Enabled, does not have PT)

from webrtc-pc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.