Coder Social home page Coder Social logo

Comments (9)

james-d-elliott avatar james-d-elliott commented on September 3, 2024 2

It may also be advisable considering this is intended for E2E tests to be able to change the BE flag AFTER the credential is created. I think being able to test the fact a change to the BE flag results in an error in integration and that the error looks appropriate is desirable.

from webauthn.

nsatragno avatar nsatragno commented on September 3, 2024 1

If we put only the option on AddCredential, then how would you test your website's behaviour on credential creation?

Here's a proposal:

  • Have backup-eligibility and default-backup-state be a setting on AddVirtualAuthenticator. This lets you test what happens for various values when creating a credential.
  • Add backup-eligibility and backup-state to AddCredential, which lets you test assertions.
  • Add a Set Backup State method to avoid having to recreate a credential.
    I'm not a fan of the remove-and-add proposal because if we add more state to the credentials, then the developer has to make sure they update all the places where they do this if they want to get the exact same credential when they update their e2e testing browser. Or worse: if your webdriver version drifts from your browser version, it might be impossible to recreate the same credential, since the old webdriver might not know about new state.

from webauthn.

emlun avatar emlun commented on September 3, 2024

I think the Add Credential API call would be the be more appropriate place for these, but I agree otherwise.

I also don't think we need to define any new operations to enable changing bs between assertions - since Add Credential includes all credential state (including the private key and signature counter), the caller can "update" bs by first calling Remove Credential and then calling Add Credential with the new bs value.

from webauthn.

MasterKale avatar MasterKale commented on September 3, 2024

I think the Add Credential API call would be the be more appropriate place for these, but I agree otherwise.

I honestly agree with you, as be and bs are definitely credential properties vs authenticator properties. However the current means of manipulating flags in authData are centralized in the Add Virtual Authenticator API call as isUserConsenting and isUserVerified so that's why I suggested the authenticator API instead...

Actually no, now I agree 100%, the means of specifying be and bs for a credential should be on Add Credential.

...the caller can "update" bs by first calling Remove Credential and then calling Add Credential with the new bs value.

I think I can get behind this, but we do have precedent for an "update" API Set User Verified. Maybe we can add a similar "Set Backup Status" API for individual credentials.

from webauthn.

agl avatar agl commented on September 3, 2024

@nsatragno

from webauthn.

fwadnjar avatar fwadnjar commented on September 3, 2024

19871987

from webauthn.

fwadnjar avatar fwadnjar commented on September 3, 2024

1987

from webauthn.

fwadnjar avatar fwadnjar commented on September 3, 2024

[email protected]

from webauthn.

MasterKale avatar MasterKale commented on September 3, 2024

This is still on my radar, I just couldn't get a draft up in time for tomorrow's WAWG meeting. I'll aim for next week's meeting instead.

from webauthn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.