Rewrite verification algorithm in a way that does not cause layer violations about vc-data-model

[OR13]

I think this is solved so long as there is no language in the core data model about validating proof, or extracting proof from a credential or presentation.

[iherman]

The issue was discussed in a meeting on 2023-12-13

• no resolutions were taken

View the transcript

2.6. Rewrite verification algorithm in a way that does not cause layer violations (issue vc-data-model#1377)

See github issue vc-data-model#1377.

Brent Zundel: rewrite verification algorithm in a way that does not cause layering violations.
… can we close this issue.

Manu Sporny: I think the text in the spec is not optimal, and it needs to align with the new interface langauge to align with the securing mechanism, and its done.
… I could not figure out how to write that text, you orie, please propose some text.

Orie Steele: Yes, seems like we're in the process of addressing follow-up PRs on verification algorithm. I expect those follow up PRs to resolve this. I'm not sure I have special text to add. Current language isn't acceptable, heading in a good direction.

Brent Zundel: Can you make a concrete suggestion that would make the text acceptable?

Orie Steele: Yes, I think Mike Jones is planning to do that already? I'll leave it to him.

Brent Zundel: can you make a suggestion for text?

Manu Sporny: I prefer to explicitly assign mike jones to this.

Brent Zundel: Mike is assigned, orie, hopefully you can communicate to mike that he is assigned.

[msporny]

PR #1393 has started to define an interface that, if merged, will enable this PR to be closed (by utilizing an interface that won't cause layer violations).

[msporny]

PR #1394 has been raised to address this issue. This issue will be closed when PR #1394 has been merged.

[iherman]

The issue was discussed in a meeting on 2023-12-19

• no resolutions were taken

View the transcript

2.3. Use new Securing Mechanism Verify Proof interface (pr vc-data-model#1394)

See github pull request vc-data-model#1394.

Brent Zundel: I'm wondering if it makes sense, Manu, to talk about 1394 before something else.

Manu Sporny: I'm fine with any order. There are 3-4 that all build on each other, but they change different things.

Brent Zundel: I was seeing the building -- but if the directionality isn't vital we'll just go.

See github issue vc-data-model#1377.

Brent Zundel: "Use new securing mechanism verify proof interface". This PR has been out for a day.

Manu Sporny: This PR is an attempt -- at addressing the same concerns that Mike is trying to address in 1397. The way Jeffrey Yaskin and I are trying to address this is by saying the securing mechanisms must provide an interface that can give you back the secured data.
… This basically says that that interface is in place. It says that a securing mechanism must define that interface and you need to take these inputs and give back these outputs.
… Once that's in place, then we can address the layering violations -- it means we can drop a lot of language around processing proof and so on. I think it achieves what Mike's PR is also achieving, or part of it, by just using the interface.
… By using the interface, we have gotten rid of mention of proof in the algorithms and the need to have a different verification mechanism algorithm. The interface makes it so we don't have to define that extra algorithm.
… It defines what the interface should be for the securing mechanisms and uses that in the verification algorithm and we have a simple, three step algorithm.

Brent Zundel: Please jump on the queue if you've read this PR.

Michael Jones: I will review it, I saw that it existed and skimmed it but decided to finish my PR first.

Brent Zundel: Thank you, Mike.
… Any other comments?

Manu Sporny: Mike, when you're reviewing, keep in mind that this isn't an either-or -- it just simplifies a lot of language in your PR from there and we can see what deltas remain.

Michael Jones: Makes sense.

Brent Zundel: Thank you both.

[iherman]

The issue was discussed in a meeting on 2023-12-20

• no resolutions were taken

View the transcript

4.7. Rewrite verification algorithm in a way that does not cause layer violations (issue vc-data-model#1377)

See github issue vc-data-model#1377.

Michael Jones: PR 1397 is also about this.

Brent Zundel: Issue 1377 a number of PRs 1393, 1394. 1394 has a number of approvals. Though some comments. 1393 not as clear. Already discussed.
… a number of PRs are in a good place likely to be merged soon. Some are not. PRs would be closed and issues closed or deferred.
… Expressing gratitude to all.

Manu Sporny: Yes, thank you to everyone for the work and passion they've put into the work! Happy Holidays! Happy New Year! :).

Phillip Long: +1 to Brent's expression of thankfulness ;-).

David Chadwick: +1.

---

[msporny]

PR #1394 has been merged. Delaying closing this until PR #1397 is revised or closed.