Coder Social home page Coder Social logo

Comments (6)

BernhardFuchs avatar BernhardFuchs commented on July 17, 2024 1

@shigeya Thx for the quick fix. The Dockerfile works now and the image is deployable. Closing this.

from did-test-suite.

shigeya avatar shigeya commented on July 17, 2024

It is intentionally not published and locally referenced. I was not aware of the issues. Will look into the issues. thanks.

from did-test-suite.

shigeya avatar shigeya commented on July 17, 2024

@OR13 I want to hear your opinion. As a solution to this issue, in PR #70, I tweaked Dockerfile and docker-compose to include both packages.

I don't like to see babel to create ./dist in the image, but I couldn't find a solution. It may be cleaner to separately publish package, but then, we have to manage two separate repositories.

Which do you prefer?

from did-test-suite.

OR13 avatar OR13 commented on July 17, 2024

@shigeya its very common to publish multiple npm packages from the same repo with lerna / yarn...

However, these approaches generally assume some burden on the maintainers...

I would be happy to take jest-did-matcher -> @did-core/jest-did-matcher , here:

https://github.com/transmute-industries/did-core/tree/main/packages

I think for now, its better to keep everything unpublished and linked with lerna where it is.

from did-test-suite.

shigeya avatar shigeya commented on July 17, 2024

@OR13 I see. Then, let's keep the package stay in the local repository. Now, Is PR #70 reasonable?

from did-test-suite.

shigeya avatar shigeya commented on July 17, 2024

@BernhardFuchs We changed jest-did-matcher to be included as part of the docker image (see PR #70 for the changes). Would you please test and confirm it's working for you?

from did-test-suite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.