Comments (6)
@shigeya Thx for the quick fix. The Dockerfile works now and the image is deployable. Closing this.
from did-test-suite.
It is intentionally not published and locally referenced. I was not aware of the issues. Will look into the issues. thanks.
from did-test-suite.
@OR13 I want to hear your opinion. As a solution to this issue, in PR #70, I tweaked Dockerfile and docker-compose to include both packages.
I don't like to see babel to create ./dist
in the image, but I couldn't find a solution. It may be cleaner to separately publish package, but then, we have to manage two separate repositories.
Which do you prefer?
from did-test-suite.
@shigeya its very common to publish multiple npm packages from the same repo with lerna / yarn...
- https://github.com/transmute-industries/did-core/tree/main/packages
- https://github.com/vuejs/vue/tree/dev/packages
- https://github.com/facebook/react/tree/master/packages
However, these approaches generally assume some burden on the maintainers...
I would be happy to take jest-did-matcher
-> @did-core/jest-did-matcher
, here:
https://github.com/transmute-industries/did-core/tree/main/packages
I think for now, its better to keep everything unpublished and linked with lerna where it is.
from did-test-suite.
@OR13 I see. Then, let's keep the package stay in the local repository. Now, Is PR #70 reasonable?
from did-test-suite.
@BernhardFuchs We changed jest-did-matcher
to be included as part of the docker image (see PR #70 for the changes). Would you please test and confirm it's working for you?
from did-test-suite.
Related Issues (20)
- universal-resolver-did-ccp not passing test HOT 3
- BLS12381_G2 unsupported from did test suite
- Test server's generate-test won't run HOT 2
- Valid id property value throws in test runs HOT 4
- How should a byte steam be encoded into JSON for a dereferenced Did URL that points to an external resource outside the DID Document? HOT 14
- Consistency on implementation JSON's properties needed for report generation HOT 6
- Hosting of did-test-suite HOT 2
- Scanning of implementation directory and test suites selection HOT 3
- Top level index.html is gone HOT 3
- Type error on endpoint
- Generate report with github pages HOT 4
- Is it possible to change width of the report? HOT 4
- Test Suite reporting broken with removal of Examples implementation HOT 3
- Every commit now results in a CI failure HOT 16
- TypeError: Cannot read property 'ancestorTitles' of undefined HOT 4
- Different test results for test-suite server
- Symbols are confusing HOT 6
- Can we smartly link from the test suite to the registry?
- Add test to check if JSON-LD DID Documents are dropping any terms
- First two Specification Cases
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from did-test-suite.