Issuer and Verifier functionality tests about vc-examples

[OR13]

"Verifier must check for a Bad Issuer" this needs to be clearer... IMO this is out of scope / business logic... knowing what a "Bad Issuer" is, is a business concern... for PRC they know this... and have no reason to forward such a VC to the verifier endpoint... in the case of Raw Materials, there is no such thing as a"Bad Issuer".... suggest we remove this one.

[mkhraisha]

yeah, that makes sense ill edit it.

[OR13]

For verification, we should add 2 negative tests for VC and VP... Invalid because of mutation of signature field... and invalid because of key rotation.. the second option will actually be hard to test over HTTP given what we have today, but its worth documenting, and skipping imo.

[OR13]

Credential expiration and Key Expiration should also be added to the list, even if we don't all support them.

[mkhraisha]

that makes sense, i added them to the optional requirements

[OR13]

Invalid Issuance Request Test Cases:

• issuer is not a did or issuer.id is not a did.
• proofPurpose is not supported in controller
• verificationMethod does not exist
• credential does not contain a context (same as malformed)

[OR13]

removing "Issuer must support the the Ed25519 Cryptographic Suite." ... this is covered by verificationMethod Tests... and we have agreed to only use this suite.... so this test is not super helpful.

[mkhraisha]

fair enough feel free to remove the same comment on the verifier

[OR13]

I question if we should keep "Verifier must return a 400 HTTP-Response if the issuer is not a did or issuer.id is not a did."

... because URIs for controllers might be desirable... and they are VC Data Model compliant... I suggest we remove this.

[OR13]

granted I suggested it initially, i think what we really want is a negative and positive test for URI and DIDs for each case.

[OR13]

I created separate test suite for this ticket, here are the results: https://w3c-ccg.github.io/vc-examples/plugfest-2020.html

[OR13]

Need to add "Issuer API returns 400 when issuer does not match "assertionMethod / verificationMethod" in options."

[OR13]

can someone convert this list to a markdown document and commit it to the repo so we can iterate on it outside of an issue?

[OR13]

Lets close this issue, and open any new issues, discuss the topic and open a PR against the markdown when we feel appropriate.