Support `kwarg` `revert_on_failure: bool = True` for contract creation built-in functions about vyper

[charles-cooper]

i don't think we should disable it, it's a different vector for bugs. we could add a skip_contract_check instead

[pcaversaccio]

@DanielSchiavini I assume you're referring to the codesize check for target. I would keep that one, since the intention of setting the kwarg revert_on_failure=False is the assumption that you're ok with the fact that the contract creation operation itself fails due to some e.g. size issues, logic issues etc., and not that the factory/blueprint itself is completely lacking. Thus, I second @charles-cooper's suggestion here.

On another note, I have an open issue to add a codesize check kwarg to raw_call here.

[DanielSchiavini]

The PR is created, I cannot invite you guys for reviewing since I'm not a maintainer

[DanielSchiavini]

@pcaversaccio should we disable the codesize check as well when revert_on_failure is False?

[pcaversaccio]

The PR is created, I cannot invite you guys for reviewing since I'm not a maintainer

Thanks - I requested Charles and myself :)