[Feature] - automatic private network set up with enable_vpc: true|false about ansible-collection-vultr

[resmo]

Hi @timdiggins

In terms of idempotency, enable_vpc/enable_vpc2 is tricky for the following reasons:

1. users have no control over the IP subnet and CIDR
2. if a user ever wants to have a 2nd VPC, it would no longer work

Therefore, our suggestion is to define a VPC as follows:

- name: Ensure a VPC is present
  vultr.cloud.vpc:
    description: default
    subnet: 10.99.1.0
    subnet_mask: 24
    region: ams

- name: Create an instance using OS
  vultr.cloud.instance:
    label: web1
    hostname: my-hostname
    os: Debian 12 x64 (bookworm)
    firewall_group: my firewall group
    plan: vc2-1c-2gb
    ssh_keys:
      - my ssh key
    vpcs:
      - default
    region: ams

Would this be an option?

P.s. As an inspiration, you might want to look at https://github.com/ngine-io/ansible-vultr-demo

[timdiggins]

@resmo - thanks that's very helpful!

I can see your points, and this does the same thing with better idempotency.
But also by adapting the name to be specific to the cluster I'm setting up then have isolation between eg. staging and production clusters (and more straightforward destruction if needed - not sure if one should clean up the vpc for temporary clusters (e.g. staging), but i guess best practice)

[timdiggins]

(Closing this - useful to have around as docs)

[timdiggins]

@resmo sorry one more question: which parameters governs identity (and thus idempotency) in the vpc module? Is it description + region?

It might help to have some documentation of this in the vpc module. (particularly asdescription (rather than name) doesn't sound like a label for an identity parameter)

[resmo]

it's description (or name as it is an alias https://docs.ansible.com/ansible/latest/collections/vultr/cloud/vpc_module.html#parameter-description) only. But I see it would make sense to probably also take the region into account. This would allow to have similar "names" in many regions.

[resmo]

Closing this as #98 has been merged.