Comments (8)
I think one fix is to remove
rethrow of exception in UpdateChecker and UpdateDownloader
because they run in different spread and CATCH_ALL_EXCEPTIONS can`t catch them.
from winsparkle.
Thanks!
run in different spread
I have no idea what you mean by that, sorry — can you please be more specific? You have the code at your disposal, you know, you could actually show the suggested code and some me some time, since you clearly already investigated this a bit…
But generally speaking, no, silently loosing errors is most definitely no the right thing to do. Making sure everything is caught and logged is.
from winsparkle.
@vslavik sorry I meant thread not spread.
from winsparkle.
@vslavik as I understand you run UpdateDownloader and UpdateChecker in different thread asynchronously. And because they are in different thread
there are no one that can catch this rethrow
catch ( ... )
{
UI::NotifyUpdateError();
throw;
}
from winsparkle.
What does "in sleep mode" in the title mean? Presumably it's about putting the computer into sleep while the host app is… doing what, exactly? Just being? Checking for updates at the moment? Actively downloading? Just having some WinSparkle UI shown but not doing anything?
from winsparkle.
@vslavik We have found what was the problem. Our user generated crash reports from winsparkle, but app in reality did n`t crash. That was exceptions in win sparkle. I think that was because they was unhandled and in different thread. We fixed this just filtering exception that do no cause crash. I close this issue
Thank you for your time.
from winsparkle.
Kindly leave the decision of closing to me.
It was obvious from the very beginning that this was an uncaught exception. Uncaught exceptions are bad. Bad things should be fixed.
from winsparkle.
Upon code review, this issue was indeed bogus: all exceptions thrown in threads are caught correctly. So your crash reported wasn't misreporting uncaught exceptions (it would be right to report that!), but was misreporting any thrown — and later caught — exceptions.
You were right to close the issue, I just didn't understand what you were saying then (I do now).
from winsparkle.
Related Issues (20)
- Internet Explorer won't be supported for long HOT 8
- Qt widgets support HOT 4
- Using cached release notes HOT 3
- Question: how to add custom HTTP header in webbrowser?
- Question: WinSparkle deadlock if automatic updates enabled and update manually triggered and installed HOT 5
- vcpkg integration HOT 1
- Question: How to close and relaunch application when installer runs HOT 1
- Add support for `<sparkle:CriticalUpdate>` HOT 4
- Windows App SDK / WinUI3 Gui ? HOT 1
- How should "Remind me later" work? HOT 1
- Support `sparkle:channel` HOT 2
- Release notes webview shown detached from its parent window HOT 9
- Possibility of check but no download? HOT 3
- Installation instructions need updated HOT 3
- Translation Support for WinSparkle HOT 1
- UI didn't show message completely HOT 2
- Using old TLS 1/1.1 HOT 4
- [Question] Silent update does not restart the application HOT 2
- Notify on WinSparkle update closed HOT 2
- Order of items seems to hide newest version. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from winsparkle.