Comments (7)
Hi.
I have posted a pull request (#45) to fix this issue, though I'm not sure if it is good solution.
Thanks
kenji uno
from winsparkle.
Hi.
If you try to show CheckUpdate dialog again in example_psdk.exe:
Delete [CheckForUpdates]
value from the registry key [HKEY_CURRENT_USER\Software\winsparkle.org\WinSparkle Example App\WinSparkle]
.
from winsparkle.
Did you try with the very latest sources (it's always worth doing)? Specifically, with sources that include 8a440b6? I'm almost sure this is a duplicate of #42 and was just fixed 3 days ago. Could you please check if that's the case?
from winsparkle.
Hi.
Did you try with the very latest sources
Yes, I have tried and worked on latest master 2ee16f6.
The fix 8a440b6 is included and it didn't fix my problem.
My issue is about "dialog's parent window":
- [Window2] owns [Window3], because wxDIALOG_NO_PARENT isn't specified. I don't know whether this is specification/bug of wxWidgets or not. You can check it by using Spy++.
- If you close [Window2] by selecting one of [Btn2][Btn3], [Window3] is also destroyed. It seems that it is done without required post processing of wxWidgets. It means that wxWidgets treats [Window3] is still alive, so app won't quit, because UI thread cannot be terminated.
ps: I'm using winsparkle on company's product and it works very well, thanks!
from winsparkle.
My issue is about "dialog's parent window":
(Your issue was with application not terminating. Nowhere in the description was it apparent that it could be related to parent-child relationship, so the assumption that it was related to 8a440b6 was IMHO a reasonable one.)
Thanks for the follow-up explanation! This parentship relationship between the windows would be correct without wxDIALOG_NO_PARENT
if [Window2] was created first; it's highly surprising to me that wx would reparent later, when the dialog is already being shown modally. That's a very valuable observation and makes the reason for #45 much cleaner, thanks a lot for that. (It's exactly the kind of description that would be great to have in the commit message itself, too.)
I still don't understand how could 8a440b6 not work, but that's a problem with me, not this issue and PR — I must still be missing something :(
from winsparkle.
Hi.
Sorry, I have found a side effect brought by this patch!
from winsparkle.
Hi.
My mention "a side effect" at the prior post is by my misunderstanding. Sorry!
from winsparkle.
Related Issues (20)
- Internet Explorer won't be supported for long HOT 8
- Qt widgets support HOT 4
- Using cached release notes HOT 3
- Question: how to add custom HTTP header in webbrowser?
- Question: WinSparkle deadlock if automatic updates enabled and update manually triggered and installed HOT 5
- vcpkg integration HOT 1
- Question: How to close and relaunch application when installer runs HOT 1
- Add support for `<sparkle:CriticalUpdate>` HOT 4
- Windows App SDK / WinUI3 Gui ? HOT 1
- How should "Remind me later" work? HOT 1
- Support `sparkle:channel` HOT 2
- Release notes webview shown detached from its parent window HOT 9
- Possibility of check but no download? HOT 3
- Installation instructions need updated HOT 3
- Translation Support for WinSparkle HOT 1
- UI didn't show message completely HOT 2
- Using old TLS 1/1.1 HOT 4
- [Question] Silent update does not restart the application HOT 2
- Notify on WinSparkle update closed HOT 2
- Order of items seems to hide newest version. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from winsparkle.