Coder Social home page Coder Social logo

Comments (4)

vsergeev avatar vsergeev commented on August 20, 2024

Currently briefsky can't distinguish Light Rain from Rain for PirateWeather: https://github.com/vsergeev/briefsky/blob/v1.4.0/src/providers/PirateWeatherProvider.ts#L5-L16 , because Light Rain isn't enumerated in the API for Icon: https://docs.pirateweather.net/en/latest/API/#icon . If it is a valid icon state coming back from PirateWeather, it should be easy to extend that mapping. If it's inferred from the other parameters, it may take a bit more logic to replicate MerrySky's conditions.

Next step would be to double check the data coming back from the API to see where the light qualifier is coming from.

from briefsky.

patel-jeel92 avatar patel-jeel92 commented on August 20, 2024

I think the response payload between merrysky and briefsky is the same for pirateweather so i think there is additional processing happening to distinguish light precipitation vs heavy vs simple precipitation.

Maybe this logic is being used and can be added to briefsky as well
https://github.com/darkskyapp/translations#precipitation-types

from briefsky.

patel-jeel92 avatar patel-jeel92 commented on August 20, 2024

Also @vsergeev is there a way to add the scroll functionality on the weather bar similar to the merrysky? I like how you can scroll on the weatherbar and the weather forecast changes. That would be a cool feature to add.

from briefsky.

Leftium avatar Leftium commented on August 20, 2024

I have a feeling the data from two different API's is being compared.

  • Notice all the temperature readings are different (this could just be due rounding/truncating)
  • Also Merry Sky shows precipitation for the entire 24 hours while BriefSky shows no precipitation for the last two hours.
  • MerrySky uses PirateWeather data
  • BriefSky uses Open Meteo data, by default. (It can be configured to use PirateWeather, though.)

My weather app actually shows many more types of precipitation, including 9 levels of "rain" (drizzle, showers, rain X light medium, heavy.) However, the forecast is not very accurate at this precision and makes it harder to read. So I am thinking of providing a level-of-detail setting for the precipitation:

When querying the weather info between two apps (MerrySky and BriefSky) I can see the two apps showing different conditions for a given day. For example, the merry sky ui for Friday (Jan 26) shows image

where as briefsky shows image

As you can see that merrysky distinguishes between light rain and rain throughout the day. However briefsky doesnt.

from briefsky.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.