Dockerhub discontinues free support about vroom-docker

[jcoupey]

We can build the image in GH actions, then push them to dockerhub and/or github packages. I'd stay on dockerhub for the time being, least hassle for existing users (and future ones really).

So be it!

[jcoupey]

I tried to go the "open source program" way for the core repo CI builds after the Travis change and in that case frankly that was quite a waste of time.

Does this only affects building the images or making them available for downstream users?

[nilsnolde]

I'm really skeptical with an "open source program" from any org, and suspect a similar waste of time.

It affects only building the images. Although docker recently also limited unauthenticated access to images, but (for now) with a fairly high limit. We can build the image in GH actions, then push them to dockerhub and/or github packages. I'd stay on dockerhub for the time being, least hassle for existing users (and future ones really).

But yeah, the next release will probably not trigger an auto-build anymore. I'll raise a PR soon for GH actions, quickly done.

[nilsnolde]

@jcoupey I just a few mins and wanted to try github actions with the new rc . can you register the docker credentials in this repository as secrets and let me know the keys? I need them before I can push images there:

      - name: Log in to Docker Hub
        uses: docker/login-action@v1
        with:
          username: ${{ secrets.DOCKER_USERNAME }}
          password: ${{ secrets.DOCKER_PASSWORD }}

[nilsnolde]

or simply name the keys as in the example and give a heads-up when they're ready:)

[nilsnolde]

I'll also throw in a test so I don't have to do that manually anymore..

[jcoupey]

Ah, didn't know I could actually share secrets with GH... DOCKER_USERNAME and DOCKER_PASSWORD are set as repo secrets now.

[nilsnolde]

solved in #45