voxpupuli / puppet-monit Goto Github PK

Ref: metrixware-echoes-tech#30

Currently metadata.json states that puppet up to and including version 5 is supported. Puppet 5.5 went EOL January 2021.

Request to add support for CentOS 8. Thank you.

Hey, thanks for the module. I was wondering if you could add a warning if httpd/mmonit is enabled and the password is unchanged. Just want to prevent those defaults from accidentally going out, without someone noticing.

Could someone please help me?

When running on Amazon Linux 2, the following error arises:

Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Function Call, monit supports Amazon Linux 2. Detected operatingsystemmajrelease is <2>.

This error leads to the following line:
https://github.com/solution-libre/puppet-monit/blob/5160f6239dc672e8e92192e36dfed09de281503e/manifests/params.pp#L68

Troubleshooting, I get the following:

[root@puppetserver etc]# cat /etc/*release*
NAME="Amazon Linux"
VERSION="2"
ID="amzn"
ID_LIKE="centos rhel fedora"
VERSION_ID="2"
PRETTY_NAME="Amazon Linux 2"
ANSI_COLOR="0;33"
CPE_NAME="cpe:2.3:o:amazon:amazon_linux:2"
HOME_URL="https://amazonlinux.com/"
Amazon Linux release 2 (Karoo)
cpe:2.3:o:amazon:amazon_linux:2

The entry in my Puppetfile is as follows:
mod 'soli-monit', '3.0.0'

Ref: metrixware-echoes-tech#28

There seems to be a FacterDB issue with Amazon operatingsystemrelease "2". When running the spec tests the test facts say it is 2017. I have verified the same issue on two different laptops and travis-ci. Is there workaround I am missing?

hey,

I noticed some syntax which are now deprectaed.
for instance:

validate_integer
validate_....

I can help with that... I hope you're open to PRs

Overriding this on focal seems to work fine e.g. FACTER_lsbdistcodename=bionic puppet agent -t I can submit a PR but I actually think this fail code is maybe too heavy handed, given it needs to be updated every dist. It would be nice if there was a param to turn off the check or if the dists were added as they come out.

Great module though, thanks!