Issues with new options... about beaker

[petems]

This also appears to mean that any parameter that already existed that didn't have an equals before (--parseonly, --verbose etc.) don't work anymore?

[anodelman]

Hm, if we can't come up with a fix reasonably quickly we should probably back out the original PR.

[electrical]

By the looks of it, when it doesn't have a value ( no key=value ) the value should be 'nil' like here

@petems can you extend your test to see if '--verbose=' exits or not?

Looking at here it automatically moves an option to a flag instead of an option when the value is nil.

[petems]

Ok, I've fixed the first part of it to use nil now: PR #313

However, when I tried to add a test to specifically check that --noop=true was absent, the test failed, even though it looked just like the future parser test:

    it 'can set the --noops flag' do
      subject.should_receive( :create_remote_file ).and_return( true )
      expect( subject ).to receive( :on ).with {|h, command, opts|
        cmdline = command.cmd_line( h )
        expect( h ).to be == agent
        expect( cmdline ).to include('puppet apply')
        expect( cmdline ).to include('--detailed-exitcodes')
        expect( cmdline ).to include('--verbose')
        expect( cmdline ).to include('--noop')
        expect( cmdline ).to_not include('--noop=')
      }
      subject.apply_manifest_on(
        agent,
        'class { "boo": }',
        :acceptable_exit_codes => (1..5),
        :noop                  => true,
        :expect_failures       => true,
      )
    end

[petems]

@electrical suggests it doesnt support the to_not include?