generating the /etc/bacula/bacula-dir.d/<node> files about puppet-bacula

[morsupil]

I suppose that there is a problem with generate_clients.rb because in case of using parameterized class the condition statement if variable =~ /^bacula_client_.*$/ will nerver match, so function_create_resources('bacula::config::client', {client => parameters}) will nerver be call.

I'm right?

[solarisfire]

I am having the same problem. Do puppetlabs not want to help with this??

[solarisfire]

Generate_clients.rb is fine, took me a little while to figure out but the whole first block from "self.to_hash.each do |variable,value|" to "function_create_resources('bacula::config::client', {client => parameters}) end end" will only be run if you are pulling your config from an ENC (dashboard). If you are doing this within the config file and define the $clients hash it is passed to the second part of Generate_clients.rb where it simply runs "function_create_resources('bacula::config::client', args[0])" because the hash is already correctly formatted to be passed directly to function_create_resources. The big problem is that the developer expects people to populate the $client hash inside /module/manifest/director.pp which is totally unclear inside the documentation and it looks like a lot of people are trying to populate this hash inside /manifests/nodes.pp which isn't getting passed to the generate_clients.rb file. I have passed a pull request in to make this config get pulled from nodes.pp which seems like a much more logical way of doing this.

[ccaum]

Sorry for lagging on this. I haven't been able to module maintenance recently. I'm going to take a look at your pull request. Unfortunately I should have written tests from the beginning to catch stuff like this.

[nibalizer]

Thanks for opening this issue. It hasn't seen activity in a while, so I'm going to close the issue. This doesn't mean that we don't think this issue is valid, we're just trying to asses what issues are still relevant. If you still need this(even if you're not willing to work on it yourself) please feel free to reopen it. Again thanks for opening the issue, users who report bugs and ask for features are some of the most important players in the open source community. Feel free to hop by #voxpupuli on freenode if you'd like to chat with us about any of this.