Comments (5)
I suppose that there is a problem with generate_clients.rb because in case of using parameterized class the condition statement if variable =~ /^bacula_client_.*$/ will nerver match, so function_create_resources('bacula::config::client', {client => parameters}) will nerver be call.
I'm right?
from puppet-bacula.
I am having the same problem. Do puppetlabs not want to help with this??
from puppet-bacula.
Generate_clients.rb is fine, took me a little while to figure out but the whole first block from "self.to_hash.each do |variable,value|" to "function_create_resources('bacula::config::client', {client => parameters}) end end" will only be run if you are pulling your config from an ENC (dashboard). If you are doing this within the config file and define the $clients hash it is passed to the second part of Generate_clients.rb where it simply runs "function_create_resources('bacula::config::client', args[0])" because the hash is already correctly formatted to be passed directly to function_create_resources. The big problem is that the developer expects people to populate the $client hash inside /module/manifest/director.pp which is totally unclear inside the documentation and it looks like a lot of people are trying to populate this hash inside /manifests/nodes.pp which isn't getting passed to the generate_clients.rb file. I have passed a pull request in to make this config get pulled from nodes.pp which seems like a much more logical way of doing this.
from puppet-bacula.
Sorry for lagging on this. I haven't been able to module maintenance recently. I'm going to take a look at your pull request. Unfortunately I should have written tests from the beginning to catch stuff like this.
from puppet-bacula.
Thanks for opening this issue. It hasn't seen activity in a while, so I'm going to close the issue. This doesn't mean that we don't think this issue is valid, we're just trying to asses what issues are still relevant. If you still need this(even if you're not willing to work on it yourself) please feel free to reopen it. Again thanks for opening the issue, users who report bugs and ask for features are some of the most important players in the open source community. Feel free to hop by #voxpupuli on freenode if you'd like to chat with us about any of this.
from puppet-bacula.
Related Issues (10)
- No Custom Storage Pools HOT 1
- No Custom Scripts before or after Job HOT 1
- Schedules definable from manifest? HOT 2
- Depricate standard filesets? HOT 1
- Add support for postgres backend database HOT 1
- custom functions must be called with a single array that contains the arguments HOT 1
- Rewrite of generate_clients.rb HOT 1
- This module not compatible with RedHat/Centos HOT 2
- new release and future maintenance HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppet-bacula.