holdout got broken about vowpal_wabbit

[petricek]

bisect points at this commit: 4416e1b

@JohnLangford @jhofman

[arielf]

Thanks Vaclav, you beat me to it. I just got to the same conclusion.
BTW: 4416e1b is a merge commit.

[petricek]

@pierce1987 any idea why holdoutgot broken in 4416e1b?

[pierce1987]

This is a merge commit so it's really messy. I will try to debug what is going on though.

[pierce1987]

Pulled a request, this should be fixed

[petricek]

Nice @pierce1987 - that was quick. For the record pull request is #265

[JohnLangford]

Merged in, thanks.

[JohnLangford]

This is fixed, thanks.

-John

On Mon, Mar 31, 2014 at 8:51 PM, Vaclav Petricek
[email protected]:

Nice @pierce1987 https://github.com/pierce1987 - that was quick. For
the record pull request is #265#265

Reply to this email directly or view it on GitHubhttps://github.com//issues/260#issuecomment-39159973
.

[jhofman]

all---sorry for the bug.

pierece, vaclav, ariel---thanks very much for the fix!

-j

On Mon, Mar 31, 2014 at 10:24 PM, John [email protected] wrote:

This is fixed, thanks.

-John

On Mon, Mar 31, 2014 at 8:51 PM, Vaclav Petricek
[email protected]:

Nice @pierce1987 https://github.com/pierce1987 - that was quick. For
the record pull request is #265<
https://github.com/JohnLangford/vowpal_wabbit/pull/265>

Reply to this email directly or view it on GitHub<
#260 (comment)

.

Reply to this email directly or view it on GitHubhttps://github.com//issues/260#issuecomment-39164747
.