Coder Social home page Coder Social logo

Comments (9)

radiodario avatar radiodario commented on May 28, 2024 2

It would be nice to see what arguments the callback is being sent, even if it follows the (error, response) convention, just for clarity's sake

from vonage-node-sdk.

alexschwarz89 avatar alexschwarz89 commented on May 28, 2024 2

Came here, (as a php developer) didn't know about (error, response) as a convention, solved my issue, but worth adding it do documentation, even if it's 2018. ;-)

from vonage-node-sdk.

kellyjandrews avatar kellyjandrews commented on May 28, 2024 1

This was added in this update - Nexmo@8ff1a55#diff-04c6e90faac2675aa89e2176d2eec7d8R72

from vonage-node-sdk.

cbetta avatar cbetta commented on May 28, 2024

@robomotic just trying to understand what you mean here. sendSMS accepts a callback that is called with an error and/or response, right? Is that not what you need?

from vonage-node-sdk.

robomotic avatar robomotic commented on May 28, 2024

@cbetta I think a little clarification is required here, I assumed the callback was the webhook endpoint as described in the Nexmo documentation. It's just an unfortunate naming, perhaps adding a more complete code snippet would help ?

from vonage-node-sdk.

cbetta avatar cbetta commented on May 28, 2024

@robomotic are you saying you just think the docs need updating?

from vonage-node-sdk.

robomotic avatar robomotic commented on May 28, 2024

@cbetta Yes or an example to explain that callback is not the url callback . :-)

from vonage-node-sdk.

AlexLakatos avatar AlexLakatos commented on May 28, 2024

Thanks for the feedback @alexschwarz89, I'll put it on my task list.

from vonage-node-sdk.

tapz avatar tapz commented on May 28, 2024

Looks like the docs have not yet been updated yet.

After integrating to Twilio, I did the same to Nexmo. Very similar apis, but in Twilio "statusCallback" means a webhook url and in Nexmo "callback" means something undocumented, which after digging is something totally different than in Twilio. Also, the options too have a parameter called "callback", which is a webhook url. Really confusing. Both apis are also a bit outdated, as they should use promises.

The description of the options parameter points to the API documentation. As the options are a JavaScript object and API parameters names like "status-report-req" it's a bit unclear if the names should be converted to camel case or not.

from vonage-node-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.