[BUG] vmdk file is incomplete when downloaded from SDDC vsphere content library via govc libary.export about govmomi

[github-actions]

Howdy 🖐   mimcdevitt ! Thank you for your interest in this project. We value your feedback and will respond soon.

If you want to contribute to this project, please make yourself familiar with the CONTRIBUTION guidelines.

[dougm]

Thank you for the detailed report @mimcdevitt
I've not tried to reproduce yet, but it does sound like expired session is the problem. The library.session.ls loop will keep the session alive, we just need to do so within the govc command. We do for library.import here:

govmomi/govc/library/import.go

Line 147 in a130044

cmd.KeepAlive(c)

Following patch adds the same for library.export, I'll take a closer look later and open a PR:

diff --git a/govc/library/export.go b/govc/library/export.go
index 45162144..c5f0fd82 100644
--- a/govc/library/export.go
+++ b/govc/library/export.go
@@ -84,6 +84,7 @@ func (cmd *export) Run(ctx context.Context, f *flag.FlagSet) error {
        if err != nil {
                return err
        }
+       cmd.KeepAlive(c)
 
        var names []string
        m := library.NewManager(c)

[mimcdevitt]

Thank you very much @dougm appreciate your help on this issue.