embed.LaunchClickOnce parsing problem about clickonceforchrome

[GoogleCodeExporter]

sorry, the first "good" url should be:

<a 
href="swebintegrations.goldmail.com/addtogoldmail/?url=http://cdn.goldmail.com/c
ontent/52659/Seasonal_Messages-Happy_Halloween_1_954c886b-1763-4144-b37c-a36cac0
19d7f.gld" id="click_once"><div id="get-gld-button"><div 
id="get-gld-button-text">Make a GoldMail With These Slides</div></div></a>

Original comment by [email protected] on 29 Sep 2011 at 10:54

[GoogleCodeExporter]

Hi Nor...

I'm having some trouble reproducing the problem from your link.  Does this 
happen 100% of the time or only occasionally? 

If I can't reproduce the problem here then there's one place that _might_ be 
causing the issue - would you be willing to try out a patched version of the 
plugin to see if it fixes your issue?

Original comment by [email protected] on 30 Sep 2011 at 3:51

[GoogleCodeExporter]

Would love to try a patch -- and yes it happens 100 percent on several machines.

Thanks for looking into this issue.

Best
Mike Conner

Original comment by [email protected] on 30 Sep 2011 at 6:38

[GoogleCodeExporter]

Hello again.

I've deployed a version of our pages to my dev site, and have a test sequence 
that seems to cause the reported behavior.  Go to:

http://goldmailmpcaffiliate.cloudapp.net/goldmail

1.  Select the Halloween #1 tile (halfway down screen) this brings up a detail 
page
2.  Click the blue button -- this will call click once via the embed code.  
Click once will install the GoldMail app to your desktop.  When the login 
screen comes up after the install, you can login with [email protected] 
pw=password.  clear the welcome popup and accept the prompt for loading 
content.  you should see slides loaded into the application
3.  Leave the application running, return to chrome, and hit the back button on 
the content page.  Select "4th of July".  Hit the blue button.  You should see 
a prompt to replace content in the client app.  Click okay.
4.  Return to Chrome.  Hit the back button again.  Now select Halloween #2.  
Hit the blue button.  This is where the parsing error will happen.  In the 
client application you will see a "no valid files" notification.  Clear this.
5.  Close Chrome.  Reopen, return to 
http://goldmailmpcaffiliate.cloudapp.net/goldmail, and select Halloween @2 
again.  You should see the notification to replace slides in the client app.

In fiddler, if you observe calls to webintegrations.goldmail.com /addtogoldmail 
you can see the mis-parsed urls when you get to step 4 above.

Hope this helps, thanks!  Michael

Original comment by [email protected] on 30 Sep 2011 at 6:56

[GoogleCodeExporter]

Thanks for the great repro.  I fixed the bug and I'll upload a new version to 
the chrome web store as soon as I figure out how to take a newly required 
1280x800 screenshot of the extension :)

Original comment by [email protected] on 1 Oct 2011 at 1:07

[GoogleCodeExporter]

Original comment by [email protected] on 1 Oct 2011 at 1:10

• Changed state: Fixed

[GoogleCodeExporter]

Well it looks like it's in the queue for manual review so the new version 
should be up in a day or so.

If you want to work around the problem until folks get the update:
The main problem is that chrome keeps a buffer of the last URL that was handed 
to the extension to launch and doesn't guarantee that buffer will be null 
terminated.  The first launch is always null terminated though which is why I 
didn't notice it before. Anyway, when when you launch 4th of July (183 
character link) followed by Halloween 2 (181 characters) the extra couple 
characters remain in the buffer.  Chrome seems to be pretty good at getting all 
users upgraded to the new version so it might not be worth your effort but if 
you make sure that every url was the same length or longer or can handle extra 
garbage at the end it should work. Ex: if you add a trailing "?foo" to the end 
of every url and somebody hits 4th then Halloween 2 they'll get "?foooo" 
instead.

Original comment by [email protected] on 1 Oct 2011 at 1:21

[GoogleCodeExporter]

Thanks so much, and thanks for the workaround suggestion as well -- I think 
we'll wait till Chrome upgrades the plugin, as we temporarily pulled the 
refresh javascript, but we've got a patch to do early next week and will 
re-implement.

Michael

Original comment by [email protected] on 1 Oct 2011 at 4:55

[GoogleCodeExporter]

Hey Michael,

It looks like the update is finally percolating out to everyone.  Could you do 
me a favor when you get it and confirm that the problem is fixed for you. 

Thanks,
Eric

Original comment by [email protected] on 5 Oct 2011 at 11:53

[GoogleCodeExporter]

Hi, Eric

Yes, we put the javascript back in and retested with 1.2.1, and are quite happy 
to see everything working as it should.  We've pushed the page to production, 
and appreciate your quick fix very much.

Cheers,
Michael

Original comment by [email protected] on 6 Oct 2011 at 5:41