`-Wimpure-v` should apply to tests as well as compiling about v

[spytheman]

For example:
./v -Wimpure-v -W test vlib/compress/zstd/
reveals that vlib/compress/zstd/zstd.v should be renamed to vlib/compress/zstd/zstd.c.v .

[JalonSolov]

I think -Wimpure-v should work without -W test... which I never knew existed.

In any case, if -Wimpure-v is turned on by default, it will definitely affect all modes.

[spytheman]

v -Wimpure-v test x_test.v
... will run the test x_test.v, ignore the warnings, then report whether the test passed (which it does).

v -Wimpure-v -W test x_test.v
... will turn the warnings into errors, then report the compilation failure.

v -Wimpure-v x_test.v will show you the warnings.

[spytheman]

It does work without -W. It just produces warnings, and warnings do not cause compilation to fail.

-W just turns warnings into errors, and errors make the compilation fail.

-prod would have worked too.

v test . just passes all the options before test as compile flags to the underlying v file_test.v etc commands.

[spytheman]

Try for example: v -Wimpure-v x_test.v , i.e. running the test directly by v, not by v test, and you will see the warnings.

[JalonSolov]

Yes, I understand, but I'm saying it should "just work" without having to know a special sequence of things to type. v -Wimpure-v <followed by anything else> should always activate that message.

[spytheman]

But it does already. v test just does not display notices, warnings, and the output of running individual _test.v files to you, unless it failed to compile it, or when it ran, but exited with status code != 0.

Currently -Wimpure-v, generates warnings. Warnings do not stop compilation -> v test will compile, and then it will run the test, which will succeed, and v test will just discard the output (including the warnings).

[spytheman]

If what you are arguing for, is towards making v test display warnings and notices by default, then that is reasonable, even though I think that it can be confusing, since in most cases, they do not matter much for tests.

[JalonSolov]

I think this is a special case, and should be displayed in all cases. Otherwise, it can cause confusion as to why tests won't work with other backends, unless you open the source and scan for C..