Coder Social home page Coder Social logo

Comments (19)

VladimirMikulic avatar VladimirMikulic commented on June 3, 2024 3

Alright, I was able to identify the issue. This happens only for CSS imports inside JS that reference external files (i.e. images).
Stay tuned, the fix is coming!

from parcel-plugin-custom-dist-structure.

VladimirMikulic avatar VladimirMikulic commented on June 3, 2024 2

@AndreaBaccolini @hrahimi270 @deivuss331 v1.1.17 has been released after so much time haha.
Thank you all for being patient. I have tested it with some of the repos in the linked issue and it seems the linking works correctly now.

Closing this now, but feel free to reopen if it does occur again!

from parcel-plugin-custom-dist-structure.

VladimirMikulic avatar VladimirMikulic commented on June 3, 2024 1

Sorry, everyone! I've been busy for the past few weeks. Hopefully, I'll be able to get on this soon.

from parcel-plugin-custom-dist-structure.

VladimirMikulic avatar VladimirMikulic commented on June 3, 2024

Hi @BskyRui.
Thank you for reporting this issue.

Which version of the plugin are you using and the version of Parcel?
I would like to see your config in package.json as well.

from parcel-plugin-custom-dist-structure.

BskyRui avatar BskyRui commented on June 3, 2024

Hi @BskyRui.
Thank you for reporting this issue.

Which version of the plugin are you using and the version of Parcel?
I would like to see your config in package.json as well.

@VladimirMikulic

package.json

{
    "name": "fe-t",
    "version": "1.0.0",
    "description": "",
    "main": "index.js",
    "scripts": {
        "start": "parcel ./src/index.html",
        "build": "rm -rf ./dist && NODE_ENV=prod parcel build ./src/index.html --out-dir ./dist"
    },
    "author": "LR",
    "license": "ISC",
    "devDependencies": {
        "@babel/core": "^7.10.5",
        "babel-plugin-import": "^1.13.0",
        "babel-plugin-module-resolver": "^4.0.0",
        "parcel-bundler": "^1.12.4",
        "parcel-plugin-custom-dist-structure": "^1.1.14",
        "sass": "^1.26.10"
    },
    "customDistStructure": {
        "config": {
            ".css": "css",
            ".js": "js",
            "images": [
                ".jpg",
                ".png"
            ],
            ".fileExtension": "folder/in/dist",
            "folder/in/dist": [
                ".file",
                ".extensions" ]
        }
    }
}

from parcel-plugin-custom-dist-structure.

VladimirMikulic avatar VladimirMikulic commented on June 3, 2024

Thanks, @BskyRui.
I have used this repo which, I think has a similar structure to your project and I wasn't able to reproduce this issue.

Is your project by any chance open-source so I can take a look?
If it's not, could you set up an example repo which reproduces the issue?

Lastly, this occurs when the project is built, right? I don't see you using development mode.

from parcel-plugin-custom-dist-structure.

BskyRui avatar BskyRui commented on June 3, 2024

@VladimirMikulic Yes, I didn't use development mode because I don't understand what the meaning of this, so I deleted it. I checked your repo, and the style file doesn't contain background: url(xxx.png). I can make a simple demo, how to send it to you?

from parcel-plugin-custom-dist-structure.

VladimirMikulic avatar VladimirMikulic commented on June 3, 2024

@BskyRui the example repo doesn't contain background: url(xyz.png), I've added it locally.

I can make a simple demo, how to send it to you?
You can simply make it a public repo on your GitHub account and delete it after I fix the issue, or you can upload it to cloud (Dropbox, GDrive etc.)

Whatever works the best for you.

By the way, development mode enables the plugin to run in development (parcel start) command.
If the flag is disabled, then it will only run on project build command (parcel build).

from parcel-plugin-custom-dist-structure.

BskyRui avatar BskyRui commented on June 3, 2024

@VladimirMikulic
I pushed source code to this repo. The master branch is the right demo which a DIV with a background image. Another branch used this plugin, the background image path in style file is wrong when npm run build.

from parcel-plugin-custom-dist-structure.

VladimirMikulic avatar VladimirMikulic commented on June 3, 2024

Thank you very much @BskyRui. I am all over it right now!

from parcel-plugin-custom-dist-structure.

AndreaBaccolini avatar AndreaBaccolini commented on June 3, 2024

Hi, no new info for this issue?

from parcel-plugin-custom-dist-structure.

geongeorge avatar geongeorge commented on June 3, 2024

@VladimirMikulic Thanks for this project.

Just linking this here :) #31 (comment)

from parcel-plugin-custom-dist-structure.

AndreaBaccolini avatar AndreaBaccolini commented on June 3, 2024

Any news about it? I ask you because it would be very useful. Thx

from parcel-plugin-custom-dist-structure.

VladimirMikulic avatar VladimirMikulic commented on June 3, 2024

Hello, @AndreaBaccolini. I appreciate you commenting on the issue.
I was wondering if you have the same problem?

Not related to this discussion, but I would like to warn you that you have misspelt name in your Github profile README. ("bame")
Thanks.

from parcel-plugin-custom-dist-structure.

AndreaBaccolini avatar AndreaBaccolini commented on June 3, 2024

@VladimirMikulic Hello yes, I also have the same problem and for now I solve it by putting the images in the folder by hand and changing the address to the link.
As for the name in my README I don't understand what you mean

from parcel-plugin-custom-dist-structure.

VladimirMikulic avatar VladimirMikulic commented on June 3, 2024

Thanks, @AndreaBaccolini. I'll see what I can do to it.
Here is what I meant about the typo in your README.

from parcel-plugin-custom-dist-structure.

hrahimi270 avatar hrahimi270 commented on June 3, 2024

Hi @VladimirMikulic.
Any updates on this issue? I'm using the last version of this plugin and having the same issue.

from parcel-plugin-custom-dist-structure.

VladimirMikulic avatar VladimirMikulic commented on June 3, 2024

Hi @hrahimi270. Unfortunately, I don't have enough time to get back to this project right now.

from parcel-plugin-custom-dist-structure.

deivuss331 avatar deivuss331 commented on June 3, 2024

Waiting for the fix too.

from parcel-plugin-custom-dist-structure.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.