Comments (4)
The controller won't return until all dependencies registered as per web request are disposed of. So, if there's a failure, the client will get a 500. It might be useful to commit early in some cases (e.g. to know if a DB uniqueness key is violated) and so you might want to introduce something like Flush on UnitOfWork. But generally, flushing all changes at the end of the web request is the essence of the Unit of Work pattern, it simplifies the code and increases performance (due to fewer db roundtrips).
from anemicdomainmodel.
The controller won't return until all dependencies registered as per web request are disposed of. So, if there's a failure, the client will get a 500.
You are not calling UnitOfWork.Dispose()
explicitly in BaseController.Ok()
. This means that it will be called when the UnitOfWork object is garbage collected. A potential exception can't bubble up back to the controller in that case. I was able to reproduce this exact behavior.
from anemicdomainmodel.
Wow you are right! I assumed an exception in a scoped dependency will bubble up but apparently they don't. It's not garbage collector, though. It's ASP.NET's built-in DI container that manages scoped dependencies and disposes of them after each web request.
I've pushed an update to UnitOfWork. Could you check on your side that it's working as expected now?
from anemicdomainmodel.
Yep, that works fine. Thanks!
from anemicdomainmodel.
Related Issues (8)
- Dollars Value Object operators HOT 1
- `DBCreationScript.txt` is missing HOT 2
- Should the Entity Class Move to an Infrastructure Project? HOT 1
- Test/Mock of ValueObject HOT 1
- Validation of DTO properties which not mapped to ValueObjects HOT 1
- Validation Logic HOT 2
- When to return result vs throw exception? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from anemicdomainmodel.