Coder Social home page Coder Social logo

Comments (7)

yotamberk avatar yotamberk commented on August 21, 2024 1

I must agree that it's weird there is no default css. I understand you give the freedom to use any css but it looks like a bug. It took me a while to realize everything was working properly...

from react-contextmenu.

vkbansal avatar vkbansal commented on August 21, 2024

This package does not contain any styling by default. So have you added the styles? Also the classnames have changed from v1.

See README for usage and styles.css for example implementation

from react-contextmenu.

vkbansal avatar vkbansal commented on August 21, 2024

Closing due to no activity. Feel free to open, if you still face the issue

from react-contextmenu.

eladmoshe avatar eladmoshe commented on August 21, 2024

Hah, I accidentally also stumbled upon this exact issue just 2 minutes after @yotamberk. Totally understand the logic @vkbansal , but since there is no live example (e.g. github pages) user who wants to just see it in action doesn't necessarily understands he needs the css.

from react-contextmenu.

vkbansal avatar vkbansal commented on August 21, 2024

@yotamberk I've update the README to be more explicit.

but since there is no live example (e.g. github pages)

@eladmoshe https://vkbansal.github.io/react-contextmenu. It is right at the top!

from react-contextmenu.

vkbansal avatar vkbansal commented on August 21, 2024

The reason I do not include styles by default is because everyone has their own preference of hiding/showing elements:

  • Some use display:none or visibility: hidden but others don't, as it causes reflows and repaints.
  • Some use opacity: 0 and pointer-events: none. But it does not work on IE.

I can't satisfy everyone. So I let them choose what ever they want.

from react-contextmenu.

eladmoshe avatar eladmoshe commented on August 21, 2024

@vkbansal totally missed the link, thanks! I think many might skip it as well since it is just a link. Maybe prefixing the link with something like "See live example:". Totally agree with your approach regarding customization. Sweet project!

from react-contextmenu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.