Comments (7)
I must agree that it's weird there is no default css. I understand you give the freedom to use any css but it looks like a bug. It took me a while to realize everything was working properly...
from react-contextmenu.
This package does not contain any styling by default. So have you added the styles? Also the classnames have changed from v1.
See README for usage and styles.css for example implementation
from react-contextmenu.
Closing due to no activity. Feel free to open, if you still face the issue
from react-contextmenu.
Hah, I accidentally also stumbled upon this exact issue just 2 minutes after @yotamberk. Totally understand the logic @vkbansal , but since there is no live example (e.g. github pages) user who wants to just see it in action doesn't necessarily understands he needs the css.
from react-contextmenu.
@yotamberk I've update the README to be more explicit.
but since there is no live example (e.g. github pages)
@eladmoshe https://vkbansal.github.io/react-contextmenu. It is right at the top!
from react-contextmenu.
The reason I do not include styles by default is because everyone has their own preference of hiding/showing elements:
- Some use
display:none
orvisibility: hidden
but others don't, as it causes reflows and repaints. - Some use
opacity: 0
andpointer-events: none
. But it does not work on IE.
I can't satisfy everyone. So I let them choose what ever they want.
from react-contextmenu.
@vkbansal totally missed the link, thanks! I think many might skip it as well since it is just a link. Maybe prefixing the link with something like "See live example:". Totally agree with your approach regarding customization. Sweet project!
from react-contextmenu.
Related Issues (20)
- DId not work? why? HOT 1
- Use of renderTag in case of Custom react element HOT 1
- Support for opening context menu using keyboard contextmenu and Shift+F10 button HOT 2
- [Feature] Prevent context click from changing document.activeElement HOT 20
- Prevent menu to show up after fire dragStart. HOT 5
- <ContextMenuTrigger> without creating additional <div> HOT 6
- Possible reason for no background color display in Electron? HOT 1
- Can I use bootstrap compatible menu? HOT 1
- Left arrow key is not working in submenu HOT 2
- Menu appear when I click left button. HOT 1
- Menu Appear behind scrollbar HOT 3
- Feature Request - Display the context menu using a React portal HOT 3
- Type declarations out of date HOT 1
- Have to click two time to dismiss HOT 1
- Prevent context menu from going outside the page HOT 1
- SubMenu custom right arrow icon. HOT 3
- onClick No Response HOT 1
- Project is no longer maintained HOT 2
- Financing HOT 2
- ctrl + click on google chrome doesn't work HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-contextmenu.