Standardize several notations about viur-core

[tsteinruecken]

For limit we have to ensure that no project out there has a bone named limit - that name must then be reserved. For getEntry and getSkel i think they're correctly named - getSkel returns the structure of that skeleton, getEntry an Entity from the datastore..

[phorward]

@tsteinruecken please let us discuss this in a ViUR round. I think it won't be a problem to forbid naming bones "limit" - I think I have one project where this is the case, so a renaming won't be a problem. And its important to make ViUR more convenient with its namings in several places.

[phorward]

Here's another one: In List-prototypes and their specific renderer functions, there called:

• self.render.editItemSuccess(skel)
• self.render.addItemSuccess(skel)
• self.render.deleteSuccess(skel) ???

why not deleteItemSuccess(), or why not editSuccess(), addSuccess() and deleteSuccess() to all??

[phorward]

For the last comment, thinking more over it, why can't we call them just "edit", "add" and "delete" same as the actions they do?

My proposal is to rename this

• edit => self.onItemEdited(skel) => self.render.editItemSuccess(skel)
• add => self.onItemAdded(skel) => self.render.addItemSuccess(skel)
• delete => self.onItemDeleted(skel) => self.render.deleteSuccess(skel)

into this:

• edit => self.onEdit(skel) => self.render.editSuccess(skel)
• add => self.onAdd(skel) => self.render.addSuccess(skel)
• delete => self.onDelete(skel) => self.render.deleteSuccess(skel)

[phorward]

I have new input for this!

Variants of relationalBone have misleading names

Problem

Why are specialized versions of relationalBone not correctly sub-classed... treeDirBone(), treeItemBone(), fileBone()
See here...

Proposal

• treeDirBone() indicates itself as relational.treedir, should be relational.tree.node
• treeItemBone() indicates itself as relational.treeitem, should be relational.tree.leaf and renamed into treeLeafBone()
  ... it makes then sense to provide a treeItemBone() which is just relational.tree to select both nodes and leafs...
• fileBone() indicates itself as treeitem.file??????, should be relational.tree.leaf.file
• hierarchyBone() indicates itself as just relational without speciality - IMHO this can be removed entirely and replaced by relationalBone().

[phorward]

Hi, I've reopened this again because it collects several issues. #39 was the first part. More will follow.

[phorward]

I'd updated the initial comment in this issue. Please be patient for further pull requests that resolve all the issues as discussed in ViUR discussion from June 26.

[phorward]

getSkel(), getEntry() proposal resolved by #48

[phorward]

#49 fixes misleading relationalBone names