Comments (3)
So there is no real advantage to assigning it to the config instead of the module. Except that it is logically together. long story short, I think we can just leave it as it was last implemented in #1158.
I think, by directly assigning to viur.core.modules.translation.Translation.adminInfo
or sub-classing it will be okay when another behavior is wanted. This should be done similar to Script
and ModuleConf
. We might remove the config for those and rely on the direct assignment or subclassing.
from viur-core.
#1158 related to this. Is it still open?
from viur-core.
#1158 related to this. Is it still open?
When I wanted to adjust something in the admin_info of my project, I realised that I can do this for all modules via the config. But not for the translations. So I thought it would be a good possibility to extend this. But since the translations have a standard admin info, it's not that easy.
The only way would be to define a method here, which is then called by the admininfo and can make changes to the admininfo. but then, in principle, I can also assign the method directly to the module using monkey patching. So there is no real advantage to assigning it to the config instead of the module. Except that it is logically together.
long story short, I think we can just leave it as it was last implemented in #1158.
from viur-core.
Related Issues (20)
- Fix xml renderer HOT 1
- Merge `viur-2to3` from `viur-cli` and `viur-core-migrate-config`
- perf: Tighten useless information from rendered structures HOT 1
- Provide a way to set UserSkel-defaults on GoogleAccount login method HOT 1
- `Skeleton.interBoneValidations` should be replaced by something useful
- `RecordBone` with a `FileBone` inside having weak file references looses its content HOT 2
- `viur-blob-locks` entities are just using `id_or_name`
- Extend `File.write()` to optionally write files to specific folders HOT 1
- Replace current SEO-features by universal SEO-Module HOT 1
- `URIBone` needed
- add/edit with pre-filled information requires for a "report no errors"-bounce
- `@CacheTime` decorator
- Update `grpcio`
- Redefine, rewrite and refactor any renderer stuff
- `NumericBone.setBoneValue` / `fromClient` does not allows large float values HOT 1
- `viur-relations` entities with `src=null` resulting `AssertionError` in `Skeleton.processRemovedRelations` HOT 1
- Add score validation to `CaptchaBone`
- `File`-module reference should use instance
- viur-core's `@jinjaGlobalFilter` `urlencode` shadows Jinja's `urlencode` filter
- How can I create a unique constraint on a skeleton over multiple bones? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from viur-core.