Coder Social home page Coder Social logo

Comments (3)

phorward avatar phorward commented on September 22, 2024 1

So there is no real advantage to assigning it to the config instead of the module. Except that it is logically together. long story short, I think we can just leave it as it was last implemented in #1158.

I think, by directly assigning to viur.core.modules.translation.Translation.adminInfo or sub-classing it will be okay when another behavior is wanted. This should be done similar to Script and ModuleConf. We might remove the config for those and rely on the direct assignment or subclassing.

from viur-core.

phorward avatar phorward commented on September 22, 2024

#1158 related to this. Is it still open?

from viur-core.

sveneberth avatar sveneberth commented on September 22, 2024

#1158 related to this. Is it still open?

When I wanted to adjust something in the admin_info of my project, I realised that I can do this for all modules via the config. But not for the translations. So I thought it would be a good possibility to extend this. But since the translations have a standard admin info, it's not that easy.
The only way would be to define a method here, which is then called by the admininfo and can make changes to the admininfo. but then, in principle, I can also assign the method directly to the module using monkey patching. So there is no real advantage to assigning it to the config instead of the module. Except that it is logically together.
long story short, I think we can just leave it as it was last implemented in #1158.

from viur-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.