Coder Social home page Coder Social logo

Comments (3)

khawkins98 avatar khawkins98 commented on August 11, 2024

I think we could make it a requirement that .vf-body be a parent of a pattern, but not on a specific element, like body.vf-body

We won't always be able to guarantee that body.vf-body > .vf-global-header ... often it might be body.vf-body > div > span > godknowswhatelse > .vf-global-header , and that won't fly with CSS Grid :(

Aside: I think the .vf-header grid takes priority over .vf-body for the .vf-global-header (pattern)

I think some of this ties into the documentation/expected behaviour.

Given that we have a few different "centering" grids at work (vf-body, vf-header and the data-protection one), perhaps we evolve the "page grids" category to do something like:

  • vf-body grid becomes vf-grid-page-center for when you want to centre your page
  • vf-header grid becomes vf-grid-header for the header, naturally!
  • vf-data-protection-banner grid becomes vf-grid-data-protection-banner

from vf-core.

khawkins98 avatar khawkins98 commented on August 11, 2024

Forgot to finish my thought: the above would open up for "exoctic" variations of vf-body/vf-grid-page-center:

  • vf-grid-page-left for when for some reason you want content fixed to the left
  • vf-grid-narrow-page-center when you need a really narrow column
  • other weird use cases that we can't quite imagine yet

from vf-core.

khawkins98 avatar khawkins98 commented on August 11, 2024

I think we're pretty aware of this issue space and the conversation here has been fully eclipsed, yes?

Being bold and closing.

from vf-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.