Comments (8)
sounds reasonable except I never met .bash scripts before. All bash scripts were had .sh extension
from wait-for-it.
@kolomenkin It is very common to see .zsh
or .fish
scripts everywhere. Using .bash
for script only supporting BASH makes perfect sense. The only time I would be fine with a script which has a bash shebang, but an .sh
extensions is when the script is POSIX compliant but wants to run on bash
from wait-for-it.
Genuine question: Is this problem solved by the fact that the first line of the script is:
#!/usr/bin/env bash
since this means the system will either find bash or fail immediately (not half-way through the script)? I'm not sure what the POSIX view is on this.
from wait-for-it.
The shebang only happens if the script is marked executable and executed like ./wait-for-it.sh
. If you explicitly run sh wait-for-it.sh
on a system where sh
is posix sh (or behaves like it), it fails partway through.
Now, one obvious solution is "ok so don't do that" but the convention is that if it's named .sh
, it should be runnable with .sh
.
This is, of course, incredibly minor.
from wait-for-it.
And this is so much more confusing given that the typical usage of this script will be in docker containers and many of them start out based on Alpine Linux which does have ash
as preinstalled shell and it is expected to be fully compatibile with POSIX sh
but then wait-for-it.sh
fails because it's actually a Bash-only script.
from wait-for-it.
Another solution, use a tool Wait4X that has binary version. π
from wait-for-it.
Another solution, use a tool Wait4X that has binary version. π
Please stop spamming the issues here. You posted the same comment multiple times now.
from wait-for-it.
Another solution, use a tool Wait4X that has binary version. smiley
Please stop spamming the issues here. You posted the same comment multiple times now.
I just mentioned a solution. Using a binary tool is a solution, so it doesn't matter if you run on which environment. π
from wait-for-it.
Related Issues (20)
- Use within dockerfile before running another command against now running app HOT 4
- Is it possible to wait for a specific path? HOT 3
- timeout command not on macOS HOT 8
- Update debian package HOT 1
- Add option to use nc (netcat) instead o bash /dev/tcp/ HOT 1
- Can multiple be supportedοΌ HOT 4
- Wait for it is not working with node:17-alpine HOT 3
- Can you please explain to me when I need to use this project? HOT 2
- Request to have a shell version of the script HOT 4
- Mistakenly submitted issue
- Support for IPv6 addresses HOT 3
- Script timesout (No such file or directory) while running with bash command HOT 2
- Support logging to stdout
- Bug: Wrong error message when the value for -t is not given
- Not working on windows 11
- Line 75 syntax error HOT 1
- Raw shell script URL `500`
- Enable TravisCI
- Debian tracker and policy recommendation flag
- How to wait for multiple ports to be ready? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wait-for-it.