'sevctl ok' and kernel reporting different status for BIOS SEV setup about sevctl

[larrydewey]

It looks like the PR was already merged, so I will open a second one to address the file check.

[larrydewey]

@cclaudio I have a branch with a patch proposal. Would you mind giving it a run to see if you see FAIL now?

[cclaudio]

@larrydewey I tested your branch in another milan system. It has hardware support for SEV, SEV-ES and SEV-SNP, and they are all enabled in the BIOS.

With your branch, sevctl ok is failing and skipping some test cases, see below. With the main branch, no tests is skipped and they all pass.

cclaudio@milan:~/src/larry/sevctl$ sudo ./target/debug/sevctl ok
[ PASS ] - AMD CPU
[ PASS ]   - Microcode support
[ FAIL ]   - Secure Memory Encryption (SME)
[ PASS ]   - Secure Encrypted Virtualization (SEV)
[ PASS ]     - Encrypted State (SEV-ES)
[ FAIL ]     - Secure Nested Paging (SEV-SNP)
[ SKIP ]       - VM Permission Levels
[ SKIP ]         - Number of VMPLs
[ PASS ]     - Physical address bit reduction: 5
[ PASS ]     - C-bit location: 51
[ PASS ]     - Number of encrypted guests supported simultaneously: 509
[ PASS ]     - Minimum ASID value for SEV-enabled, SEV-ES disabled guest: 100
[ PASS ]     - SEV enabled in KVM: enabled
[ PASS ]     - SEV-ES enabled in KVM: enabled
[ PASS ]     - Reading /dev/sev: /dev/sev readable
[ PASS ]     - Writing /dev/sev: /dev/sev writable
[ PASS ]   - Page flush MSR: ENABLED
[ PASS ] - KVM supported: API version: 12
[ PASS ] - Memlock resource limit: Soft: 67108864 | Hard: 67108864
Error: One or more tests in sevctl-ok reported a failure

[cclaudio]

I was discussing this with @larrydewey and we got to the following conclusion.

• The tests were failing because the msr kernel module was not loaded.
• To test if the module is loaded, his patch just needs to check if the /dev/cpu/0/msr file exists.

Thank you @larrydewey!

[larrydewey]

Added a change in the msru pr which will return a specific error when the device file is not present.

[larrydewey]

PR merged, and msru v0.2.0 released. Just waiting on the next release of sevctl

[tylerfanelli]

@larrydewey @cclaudio Releasing a new sevctl version now. Has this issue been fixed?