Coder Social home page Coder Social logo

Optional Group by Species about pokenurse HOT 1 OPEN

furier avatar furier commented on July 17, 2024 2
Optional Group by Species

from pokenurse.

Comments (1)

vinnymac avatar vinnymac commented on July 17, 2024 1

I could see us adding an option to hide the species and expand all of the Pokemon into one table. This type of thing can't be considered until we finish the new table in React though.

EDIT: We did react a while ago. Now that I have spent more time with the code, it looks like making this happen will be a huge overhaul. The data was by default grouped by species around the time I started contributing so I think we would need to start rethinking about how we use the data. I am thinking we would just have a giant array or object keyed by id, and that will be where we get all the pokemon data from and manipulate it, and sync state. Then we would need to have an option where we start grouping by species if we need to using a groupBy method from something like lodash.

This would be difficult to do because of the fact that all the current logic expects everything to be grouped by species. So undoing all of that will likely break the entire app, and the changes will be quite fragile and bug prone. If we do this it will require heavy testing and will change the way the data flows in redux a lot.

from pokenurse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.