Comments (1)
Hi @falkben
Thank you for your detailed report.
It seems that starlette doesn't like reading the request body after starting the response. I changed the test to consume the request body and then start the response and this seems to work fine (#57).
I also created this example app without asgi-testclient to be sure it's not a bug in the test client, and it seems that the problem is in starlette:
# example.py
from starlette.applications import Starlette
from starlette.responses import StreamingResponse
app = Starlette()
async def buffered(request):
chunks = [chunk async for chunk in request.stream()]
async def gen(chunks):
for chunk in chunks:
yield chunk
return StreamingResponse(gen(chunks))
async def unbuffered(request):
return StreamingResponse(request.stream())
app.add_route("/buffered", buffered, methods=["POST"])
app.add_route("/unbuffered", unbuffered, methods=["POST"])
"""
1. Create a test file
dd if=/dev/urandom of=./file count=1024 bs=1024
2. Run server
uvicorn example:app
3. Check buffered stream works
curl -v -X POST localhost:8000/buffered --data-binary @file --output -
4. Test unbuffered stream doesn't work (empty response)
curl -v -X POST localhost:8000/unbuffered --data-binary @file --output -
"""
I was going to open a discussion in Starlette but I found this one reporting a similar problem
from async-asgi-testclient.
Related Issues (20)
- WebSocket connection with query params - failed HOT 4
- Better way to provide headers for each request HOT 3
- Add multipart support
- [Feature Request] Inheriting cookies from TestClient to WebSocketConnection. HOT 4
- File uploading error HOT 5
- Compatibilty with aiohttp.ClientSession? HOT 4
- [odd] issue trying to `poetry add` this package HOT 2
- No way to add multiple files with the same name HOT 2
- Support for aridane HOT 1
- WebSocket connection scope's subprotocols not properly constructed
- Request `Cookie` header is invalid
- Bug: websocket scope error HOT 1
- Allow setting the full request URL including a hostname / port
- Cannot use `wss://` as the scheme for WebSocket tests
- Issues with compliance to the ASGI specification HOT 1
- client can't handle redirect of absolute paths HOT 1
- Client unable to handle websocket connection rejections HOT 2
- [feature request] trio support
- TestClient calls wrong methd when fastapi.APIRouter().add_api_router() is used to setup the router
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from async-asgi-testclient.