Coder Social home page Coder Social logo

Comments (1)

masipcat avatar masipcat commented on June 21, 2024

Hi @falkben

Thank you for your detailed report.

It seems that starlette doesn't like reading the request body after starting the response. I changed the test to consume the request body and then start the response and this seems to work fine (#57).

I also created this example app without asgi-testclient to be sure it's not a bug in the test client, and it seems that the problem is in starlette:

# example.py
from starlette.applications import Starlette
from starlette.responses import StreamingResponse

app = Starlette()


async def buffered(request):
    chunks = [chunk async for chunk in request.stream()]

    async def gen(chunks):
        for chunk in chunks:
            yield chunk

    return StreamingResponse(gen(chunks))


async def unbuffered(request):
    return StreamingResponse(request.stream())

app.add_route("/buffered", buffered, methods=["POST"])
app.add_route("/unbuffered", unbuffered, methods=["POST"])

"""
1. Create a test file
dd if=/dev/urandom of=./file count=1024 bs=1024

2. Run server
uvicorn example:app

3. Check buffered stream works
curl -v -X POST localhost:8000/buffered --data-binary @file --output -

4. Test unbuffered stream doesn't work (empty response)
curl -v -X POST localhost:8000/unbuffered --data-binary @file --output -
"""

I was going to open a discussion in Starlette but I found this one reporting a similar problem

from async-asgi-testclient.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.