Comments (3)
I was taking a look into this and is the makefile even still used? I try it and it is missing csv_parser
target.
I was working with the cmake file and it looks like you don't have a check for the gcc version 8 like you do in the makefile. On Ubuntu the default is 7 and when i try to use c++17 this doesn't have the header file <charconv>
which doesn't appear till version 8.
What is the status of this issue?
from csv-parser.
The Makefile is really only used for code coverage purposes. I've tried using a popular CMake code coverage configuration but had some difficulty.
from csv-parser.
Just FYI @vincentlaucsb - I'm using csv-parser in a large project where all the build is managed by CMake, and I like to compile and link external libs (to improve build time for modified proprietary project files).
I had an issue linking the csv-parser on MacOS. It was having issues linking the code coverage tests.
I fixed it by removing this section from the CMakeLists.txt:
if(MSVC)
# Make Visual Studio report accurate C++ version
# See: https://devblogs.microsoft.com/cppblog/msvc-now-correctly-reports-__cplusplus/
# /Wall emits warnings about the C++ standard library
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /EHsc /Zc:__cplusplus /W4")
else()
# Ignore Visual Studio pragma regions
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unknown-pragmas")
set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} --coverage -Og")
endif(MSVC)
It would be great if there was a way to build the library for end users without running any code coverage tests (obviously a development process).
from csv-parser.
Related Issues (20)
- the empty() function doesnt work correctly
- try_parse_hex() has some issues HOT 1
- Quote character not removed properly HOT 1
- CSVReader fails with files bigger than 10 MB when constructed with std::ifstream HOT 2
- not parser this situation
- mingw cross-compilation fails when looking for Windows.h
- Values with number and dash data type are parsed as integer instead of string
- Bug: Segmentation Fault on `CSVStat` when No Rows HOT 1
- The documentation site is not working HOT 2
- to the lib with csv unicode charset HOT 1
- float values with leading '+' are not recognized HOT 1
- Request: new recipe for conan 2.0
- AddressSanitizer: heap-use-after-free on large dataset HOT 2
- Infinite loop when parsing lines longer than 10MB / ITERATION_CHUNK_SIZE HOT 1
- csv single_header slow to read data.. HOT 3
- Fields with embedded newlines HOT 2
- Problem to get header content! HOT 1
- Parsing broken on cursed newlines HOT 1
- csv-writer problem? HOT 1
- Very minor readme issue HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from csv-parser.