Coder Social home page Coder Social logo

Comments (3)

vinceliuice avatar vinceliuice commented on July 20, 2024

It's not frame, you need change this

border: 2px solid $primary;

from graphite-gtk-theme.

dxps avatar dxps commented on July 20, 2024

Thanks for the feedback!
Tried with both a variable (defined in src/sass/_colors.scss file) or "hardcoded" like this:

/**********************
 * Window Decorations *
 **********************/
decoration {
  transition: $transition-shadow;

  @if $rimless == 'true' {
    border-radius: $window-radius;
    box-shadow: $shadow-z16, 0 0 36px transparent;
  } @else {
    border-radius: $window-radius + 2px;
    box-shadow: $shadow-z4, 0 0 16px transparent;
    border: 2px solid #5C5C5C;  // <---- LIKE THIS (LINE 3614 on src/sass/gtk/_common-3.0.scss)
    background-clip: border-box;
  }
  ...

the problems are:

  1. Installing it using ./install.sh it seems that this #5C5C5C is not reflected in the result:
    • in any of theme flavors installed in ~/.themes/ directory, grep -R "5C5C5C" * shows no finding).
    • in the UI, the white border is still there (of course, changed to other themes and back, reload X11 also)
  2. Trying to install without the border using ./install --tweaks rimless fails
    and no Graphite flavor gets "installed" into ~/.themes directory)
    $ ./install.sh --tweaks rimless
    
    ** (process:1011735): WARNING **: 14:40:09.222: Failed to set RT scheduler: Operation not permitted
    Install Rimless version! ...
    Installing '/home/dxps/.themes/Graphite'...
    cp: target 'Graphite/Graphite-gtk-theme/src/sass/_tweaks-temp.scss' is not a directory
    $

I don't wanna offload all of these to you, I'll try to solve on my own and get back with a feedback, but I wanted to raise the issues and what I tried in this regard.

Thanks.

from graphite-gtk-theme.

dxps avatar dxps commented on July 20, 2024

Solved it! 🎉

I admit I was in-between calls (work from home as most of us) and in a hurry to solve it while writing the previous message.

What I did was:

  1. Just used cp -f ${SRC_DIR}/sass/_tweaks.scss ${SRC_DIR}/sass/_tweaks-temp.scss, no recursive flag, and no error.
  2. After changing the SCSS, used ./parse-sass.sh (quite obvious, ofc), then ./install.sh.

Now, I feel I'm back in control.

Once again, thank you very much for providing this lovely theme! 🙏

from graphite-gtk-theme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.