Add support for setImageResource about roundedimageview

[vinc3m1]

There is already support for setImageResource, but it's not very efficient and effectively sets the drawable twice: https://github.com/vinc3m1/RoundedImageView/blob/master/roundedimageview/src/com/makeramen/RoundedImageView.java#L262

Actually, holding the resource id isn't that bad, I'm not sure why I didn't do that in the first place... I think I got it confused with setImageURI

[AndroidDeveloperLB]

maybe that's because i've done a checkout a long time ago that i couldn't see this function and added my "patch" to it.

maybe you should look at the android code of imageView and get other ideas? even though their code is quite large, it could help you with possible optimizations...

[AndroidDeveloperLB]

I think my code suggestion is flawed. Not sure what's the reason.

[AndroidDeveloperLB]

I think this could be the correct changes:

@OverRide
public void setImageDrawable(final Drawable drawable) {
mResId = 0;
if (drawable != null) {
mDrawable = RoundedDrawable.fromDrawable(drawable);
updateDrawableAttrs();
} else {
mDrawable = null;
}
super.setImageDrawable(mDrawable);
}

@OverRide
public void setImageBitmap(final Bitmap bm) {
mResId = 0;
if (bm != null) {
mDrawable = new RoundedDrawable(bm);
updateDrawableAttrs();
} else {
mDrawable = null;
}
super.setImageDrawable(mDrawable);
}

@OverRide
public void setImageResource(final int resId) {
if (mResId == resId && resId != 0)
return;
if (resId == 0)
setImageDrawable(null);
else
setImageDrawable(getResources().getDrawable(resId));
mResId = resId;
}

[vinc3m1]

see 97b04ea

Should theoretically be faster, but might not be complete if getResources() is ever null for some reason...

[AndroidDeveloperLB]

on which cases getResources returns null?
i don't think it's possible...

[vinc3m1]

Not sure, but there's a null check in resolveUri in ImageView.java source.

[AndroidDeveloperLB]

weird.

anyway, so now the code on this library is better, and uses the resources' drawable in a better way?

[vinc3m1]

it should, but the way it was working before was fine too

[AndroidDeveloperLB]

thanks.