Comments (9)
I certainly have formatting and cleaning the code on my agenda for the forthcoming release. Thank you for the link. Will strictly enforce it :)
from creditcardview.
Hi @VenomVendor,
I have tried to enforce the suggestions and have formatted some of the code. Would appreciate if you could take a look and point out additional recommendations if any :) Appreciate your contribution. Thank you!
from creditcardview.
Updated code with pull request.
from creditcardview.
Hi @VenomVendor,
This is excellent! I have learnt so many new things by just analyzing the formatting you did! I just had one question, which is if you are able to see the layout correctly in the activity_main file of the sample project? I am getting some new errors in the preview screen. Wanted to know if you were seeing the same thing.
from creditcardview.
Yes, I tested against sample project.
Can you tell what exactly is the error?
from creditcardview.
Nevermind, looks like a bug in Android Studio. Restart, Build, Clean seems to have solved it!
from creditcardview.
It was an error in the layout preview screen, on the lines of cannot resolve resource and pointing to the layout inflater line.
from creditcardview.
Yes doing just that. In a minute :)
from creditcardview.
Accepted your pull request and closing this issue. Really appreciate your contribution! Thank you.
from creditcardview.
Related Issues (20)
- expiration defaults to standard keyboard HOT 1
- Can't use with RecyclerView HOT 6
- Cvv max length dinamyc by CardType HOT 1
- Card type auto detection not working on "All but last four" number format
- 1.0.3 declared but getting code inconsistent with (older than) release commit HOT 2
- Font problem HOT 3
- Does Not display programmatically HOT 4
- I want to put CVV HOT 1
- Issues with CreditCardView HOT 5
- passing value into card programmatically HOT 10
- Change card programmatically not work in DialogFragment HOT 1
- [BUG] crashes when type is set to 'none' HOT 5
- Use card View instead of RelativeLayout
- Keep aspect ratio HOT 1
- Can't set plain background on Android 4.2 HOT 1
- How to save values
- Add set and get Cvv function HOT 4
- you have a problem with crediCardView.getCardNumber();
- BMO credit card
- Nesecito
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from creditcardview.