Coder Social home page Coder Social logo

Code Style Guidelines about creditcardview HOT 9 CLOSED

vinaygaba avatar vinaygaba commented on June 25, 2024
Code Style Guidelines

from creditcardview.

Comments (9)

vinaygaba avatar vinaygaba commented on June 25, 2024

I certainly have formatting and cleaning the code on my agenda for the forthcoming release. Thank you for the link. Will strictly enforce it :)

from creditcardview.

vinaygaba avatar vinaygaba commented on June 25, 2024

Hi @VenomVendor,
I have tried to enforce the suggestions and have formatted some of the code. Would appreciate if you could take a look and point out additional recommendations if any :) Appreciate your contribution. Thank you!

from creditcardview.

VenomVendor avatar VenomVendor commented on June 25, 2024

Updated code with pull request.

from creditcardview.

vinaygaba avatar vinaygaba commented on June 25, 2024

Hi @VenomVendor,
This is excellent! I have learnt so many new things by just analyzing the formatting you did! I just had one question, which is if you are able to see the layout correctly in the activity_main file of the sample project? I am getting some new errors in the preview screen. Wanted to know if you were seeing the same thing.

from creditcardview.

VenomVendor avatar VenomVendor commented on June 25, 2024

Yes, I tested against sample project.
Can you tell what exactly is the error?

from creditcardview.

vinaygaba avatar vinaygaba commented on June 25, 2024

Nevermind, looks like a bug in Android Studio. Restart, Build, Clean seems to have solved it!

from creditcardview.

vinaygaba avatar vinaygaba commented on June 25, 2024

It was an error in the layout preview screen, on the lines of cannot resolve resource and pointing to the layout inflater line.

from creditcardview.

vinaygaba avatar vinaygaba commented on June 25, 2024

Yes doing just that. In a minute :)

from creditcardview.

vinaygaba avatar vinaygaba commented on June 25, 2024

Accepted your pull request and closing this issue. Really appreciate your contribution! Thank you.

from creditcardview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.